1161943 - Camera focus and picture button not working when invoked from messages app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

STR:
 - tap attach in SMS
 - select camera app

expected :
 I can use camera focus and picture button to adjust focus and take a picture 

actual:
 this used to work but somehow regressed and don't work

Comment 1

[:gerard-majax]

[Blocking Requested - why for this release]: dogfood regression, breaks UX

Comment 2

[:gerard-majax]

Gaia 29c2ecb90453d6cead8800dd5ef5357dde0a73b7 was fine.

Comment 3

[:gerard-majax]

41ad88e7ac0468fe45fb4549d799ce9ed56badb1 is the first bad commit
commit 41ad88e7ac0468fe45fb4549d799ce9ed56badb1
Author: albertopq <[e-mail]>
Date:   Thu Apr 23 18:56:34 2015 +0200

    Bug 1121316 - Refactoring action_menu to be a system_dialog

:040000 040000 e6070f0897f3cf1325bdd67f7dfce682a8c52c27 fdbe9dbf7613c976623d5cbf7db0edd60d0a4e98 M	apps

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1161943-camera-button-activity > mozilla-b2g:master

Comment 5

[:gerard-majax]

Comment on attachment 8602135 [details] [review]
[gaia] albertopq:1161943-camera-button-activity > mozilla-b2g:master

Fixes the issue for me, thanks!

Comment 6

[Alberto Pastor [:albertopq]]

Comment on attachment 8602135 [details] [review]
[gaia] albertopq:1161943-camera-button-activity > mozilla-b2g:master

I think we should make this._activeApp a 'get' function that always return the topMost, but I'm not familiar enough with the code to see if that would cause any issue. I'll create a new bug for implementing that if you think it makes sense, Alive.

Comment 7

[Gregor Wagner [:gwagner]]

Can we do a branch check?

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

I can't reproduce this bug. Camera focus and shutter button work as expected when invoked from Messages app. Is this device specific?

Tested on:
Device: Flame
BuildID: 20150506010204
Gaia: 3e6fd1e0a478af2c95d09ce95c2c6de2de2fec14
Gecko: ba44099cbd07
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Leaving qawanted for others to attempt.

Comment 9

[Brogan Zumwalt [Inactive]]

Unable to reproduce on Flame 3.0 nightly or Flame Mozilla-Central Engineering build (on the off chance that this issue wasn't present in nightly builds yet)

Tap to focus and take picture button function as expected when opening camera from messages app.

Leaving qawanted to see if anyone else can reproduce.

Nightly:
Device: Flame 3.0
Build ID: 20150506010204
Gaia: 3e6fd1e0a478af2c95d09ce95c2c6de2de2fec14
Gecko: ba44099cbd07
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Mozilla-Central:
Device: Flame 3.0
Build ID: 20150506030016
Gaia: eb3f82f3b947f1ed52fa4e9246bed0f0b3e49785
Gecko: 60349cbc3d4e
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Comment 10

[Alberto Pastor [:albertopq]]

Just to clarify:

1.- open Sms app and create a new message
2.- click on the attachment icon and select camera
3.- WITHOUT clicking on the screen, click the shutter (hardware) button (or volume buttons otherwise)

Expected:

It takes a picture

Actual:

It doesn't.

Note that clicking on the screen makes the buttons work again.

I reproed it on latest. It is probably present on 2.2, but not with these STR. The bug Alex was mentioning showed up this issue, despite is not the root cause.

I hope it helps.

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

It was not mentioned anywhere in comment 0 that the shutter button refers to the hardware one that was recently implemented. Also the 'focus' action in comment 0's expected behavior leads us to try and manually tap on screen to focus which will result in bug not reproduce.

Hardware shutter button is NOT implemented in v2.2 so it is not applicable. Not setting its tracking flag.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8602135 [details] [review]
[gaia] albertopq:1161943-camera-button-activity > mozilla-b2g:master

I don't think so - sometimes we just want to know the bottom most window and sometimes we want top most one.

I am thinking that we should absort this in AppWindow.focus and AppWindow.blur;
that is to say, maybe we should just do:

this.getTopMostWindow().focus in BrowserMixin.focus() and
this.getTopMostWindow().blur in BrowserMixin.blur()
(Pay attention not to create infinite loop)

With this we don't need to get the top most window to focus/blur in all window managers (for example attention window manager, overlay window manager...)

What do you think? If you agree, could you try with this and have some unit tests?

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8602135 [details] [review]
[gaia] albertopq:1161943-camera-button-activity > mozilla-b2g:master

Nice, thank you!

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b8e9fdf58fa64ce5393a4f305b8df58d2190ac6b

Comment 15

[Pi Wei Cheng [:piwei] (inactive)]

This issue has been verified fixed on Flame 3.0. Pressing on volume button now takes a picture when invoked from Messages app.

Device: Flame (319MB, KK, full flashed)
BuildID: 20150529073021
Gaia: a0d4c222c1f1a8d2954539dac1537a1166aab320
Gecko: 9738f055d98c
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0