1162019 - [Bluetooth2][Daemon][PTS][HFP] Test case - TC_AG_COD_BV_02_I inconc

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Will Wang [:WillWang]]

Attachment: 0505-TC_AG_COD_BV_02_I-inconc.zip

### ENV
Flame/Bluedroid

### STR
1. PTS 6.0.1
2.TC_AG_COD_BV_02_I
 
### Expected
Pass 

### Actual
Test case : TC_AG_COD_BV_02_I started
	- SDP Service record for PTS: 'Handsfree HF' successfully registered
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- AT: SPP connect succeeded
	- AT: Service Level Connection established
	- AT: post SLC command sequence complete
	- MTC: IUT was able to connect to HF when CoD set to 0x200404
	- AT: Service Level Connection disabled
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- AT: SPP connect succeeded
	- AT: Service Level Connection established
	- AT: post SLC command sequence complete
	- MTC: IUT was able to connect to HF when CoD set to 0x202404
	- AT: Service Level Connection disabled
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- AT: SPP connect succeeded
	- AT: Service Level Connection established
	- AT: post SLC command sequence complete
	- MTC: IUT was able to connect to HF when CoD set to 0x200408
	- AT: Service Level Connection disabled
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- Guard timer timed out
	- MTC: Test case ended
	 -Final Verdict: INCONC
TC_AG_COD_BV_02_I finished

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Experiment-patch-for-PTS-TC_AG_COD_BV_02.patch

The root cause is the same as https://bugzilla.mozilla.org/show_bug.cgi?id=993275#c1.
This special case was handled in gecko before, but this icon mapping has been moved to gaia in APIv2.

This attachment is an experiment patch for addressing the issue in gaia.
I can pass the test case by applying this patch.

Ian, could you give some comments from gaia point of view?

Thanks,
Jocelyn

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

I believe the behavior are the same on v2+HAL and v2+daemon.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

FYI, BT APIv1 handles this case in https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp?#723-734

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

(In reply to Jocelyn Liu [:jocelyn] [:joliu] from comment #3)
> FYI, BT APIv1 handles this case in
> https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/
> BluetoothServiceBluedroid.cpp?#723-734

IMO, I think handling it in gecko might not be feasible in BT APIv2 since gecko only saves cod values of remote devices and they cannot be substituted like we done in BT APIv1.

Comment 5

[[e-mail], [e-mail]]

Take over the issue since device type is defined in Gaia side for BT APIv2.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] ian-liu:bluetooth/bug1162019_identify_major_service_class_audio > mozilla-b2g:master

Comment 7

[[e-mail], [e-mail]]

Comment on attachment 8603964 [details] [review]
[gaia] ian-liu:bluetooth/bug1162019_identify_major_service_class_audio > mozilla-b2g:master

Jocelyn, I prepare a patch to identify this rare case. For those devices, which are not mapping in Gaia major device class(Computer, Phone, LAN/Network Access Point, Audio/Video, Peripheral and Imaging), but they are belong to major service class - audio. It will be mapping in type 'audio-card'.

My patch is different from checking major service class. I refine it with '=== 0x100'. Because '&' will let 'Telephony (Cordless telephony, Modem, Headset service, ...)' and 'Information (WEB-server, WAP-server, ...)' also belong to type 'audio-card'. But not sure it will pass test case - TC_AG_COD_BV_02_I or not. Perhaps, the criteria is too high. Need your feedback here. Thanks.

Comment 8

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8603964 [details] [review]
[gaia] ian-liu:bluetooth/bug1162019_identify_major_service_class_audio > mozilla-b2g:master

Per offline discussion, we could use & 0x100 directly to check the bit for Audio.
I have applied the updated patch, the test case is passed now.

Thanks,
Jocelyn

Comment 9

[[e-mail], [e-mail]]

Comment on attachment 8603964 [details] [review]
[gaia] ian-liu:bluetooth/bug1162019_identify_major_service_class_audio > mozilla-b2g:master

Arthur, I would like your review for the pull request. Thanks.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8603964 [details] [review]
[gaia] ian-liu:bluetooth/bug1162019_identify_major_service_class_audio > mozilla-b2g:master

The patch is looking good to me, thanks.

Comment 11

[[e-mail], [e-mail]]

Since the pr is landed, we can close the issue now.

Gaia/master: https://github.com/mozilla-b2g/gaia/commit/1923d78bdfd3462c64c5db2cd8afd8cd72c7fbd7