1162036 - onPurgeSessionHistory() empties pending tabs and then just leaves them there

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Currently, sanitizing browser history makes sessionstore throw away most of its state and recollect it. Pending/restoring tabs however are simply "cleared", they keep their icon and title but if you switch to them you just see "about:blank" and nothing happens. Looks like I also broke that functionality with the TabStateCache as quitting the browser in that state brings back all these emptied tabs.

Instead of leaving empty tabs around, that even confuse users due to them still having the same title and favicon, we should simply remove them. That resembles a lot better what actually happens and fixes the TabStateCache problem too.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1162036-Remove-pending-restoring-tabs-when-recei.patch

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8602101 [details] [diff] [review]
0001-Bug-1162036-Remove-pending-restoring-tabs-when-recei.patch

Review of attachment 8602101 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/SessionStore.jsm
@@ +1260,5 @@
>      this._forEachBrowserWindow(function(aWindow) {
> +      let tabs = aWindow.gBrowser.tabs;
> +      // Remove pending or restoring tabs instead of just emptying them.
> +      for (let i = tabs.length - 1; i >= 0; i--) {
> +        if (tabs[i].linkedBrowser.__SS_restoreState) {

Note to self: We'll need to get rid of __SS_restoreState one of these days.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #2)
> Note to self: We'll need to get rid of __SS_restoreState one of these days.

Indeed. Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0cecdb107e91

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for e10s failures.
https://hg.mozilla.org/integration/fx-team/rev/38c0996aa366

https://treeherder.mozilla.org/logviewer.html#?job_id=2958508&repo=fx-team

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d1431d237095

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Pushed again with a small fix so that we don't try to remove the last tab of a window when purging shistory.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d1431d237095

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using:
- latest Nightly, build ID: 20150617030205.
- latest Aurora, build ID: 20150617004006.