1163700 - "Clear Recent History..." closes unloaded tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: dataloss, regression

Steps To Reproduce:
0. Start Nightly with newly created profile
1. Open several tabs
2. Exit and restart the browser
3. Click "Restore Previous Session" from History Menu
4. Click "Clear Recent History..." from History Menu
5. Click [Clear Now] in the Clear All History dialog

Actual Results:
Unloaded tabs are unexpectedly closed.

Expected Results:
Tabs should not be closed.

Regression window
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=855bbeb7d41f&tochange=182674a08067

Regressed by:
d1431d237095	Tim Taubert — Bug 1162036 - Remove pending/restoring tabs when receiving browser:purge-session-history instead of leaving empty tabs r=Yoric

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Previously we simply emptied pending tabs but didn't notify the user about it, i.e. the favicon and title stayed but clicking the tab simply showed about:blank. This was an explicit change to be a little more clear about what's happening here.

Comment 2

[Alice0775 White]

(In reply to Tim Taubert [:ttaubert] from comment #1)
> Previously we simply emptied pending tabs but didn't notify the user about
> it, i.e. the favicon and title stayed but clicking the tab simply showed
> about:blank. This was an explicit change to be a little more clear about
> what's happening here.

So, Bug 1162036 fixed in wrong way.
Underlying bug should be fixed first. 
I've filed Bug 1163745.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

This is going to be fixed by bug 1163745.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1163700-Revert-changes-from-bug-1162036-r-Yoric.patch

To fix bug 1163745, for a start, I think we should just revert the changes from bug 1162036 and uplift that to Aurora.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8616449 [details] [diff] [review]
0001-Bug-1163700-Revert-changes-from-bug-1162036-r-Yoric.patch

Review of attachment 8616449 [details] [diff] [review]:
-----------------------------------------------------------------

rubberstamp

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/571e6f0262a2

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

This was merged but wasn't resolved.

https://hg.mozilla.org/mozilla-central/rev/571e6f0262a2

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8616449 [details] [diff] [review]
0001-Bug-1163700-Revert-changes-from-bug-1162036-r-Yoric.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1162036
[User impact if declined]: pending tabs are removed when purging shistory
[Describe test coverage new/current, TreeHerder]: 
[Risks and why]: low risk, straight backout
[String/UUID change made/needed]: none

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8616449 [details] [diff] [review]
0001-Bug-1163700-Revert-changes-from-bug-1162036-r-Yoric.patch

Important regression, taking it.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8a53f67d0f6c

Comment 11

[Cornel Ionce [:noni] [Hubs QA]]

Reproduced the initial issue on 2015-05-11 Nightly, build ID: 20150511122605.


Confirming the fix on:
- latest Nightly, build ID: 20150617030205.
- latest Aurora, build ID: 20150617004006.

Tested on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit.