1162055 - [ESR 38.0] Firefox Hello available via Firstrun experience

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Ada [:adalucinet]]

Reproducible on ESR 38.0 (Build ID: 20150505103531)
Affected platforms: OS X 10.9.5, Ubuntu 14.04 x32, Windows 7 x64

Firefox Hello feature is displayed in Firstrun (https://www.mozilla.org/en-US/firefox/38.0/firstrun/) as shown in the below screenshots, although the feature is disabled as per bug 1141058. This may be very confusing for certain users.

Screenshots: 
http://i.imgur.com/anKtbHz.png
http://i.imgur.com/4AXMPgV.png

Comment 1

[Sylvestre Ledru [:Sylvestre]]

We should probably disable the firstrun for esr. It would be easier and faster.

Comment 2

[:shell escalante]

Hi Sylestre,  Do you know what Product:Component i should move this bug under who handles switching on/off ESR stuff?  

Corey - is that your team that could help turning off a first run feature in 38.0 ESR build?  Hello won't be available in ESR this time around.

Comment 3

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

If the request is to disable /firstrun completely for 38.0ESR, that's not us.

If the request is to only turn off Hello for 38.0ESR, that is us, and we'd have to look into disabling a feature mid-tour based on version. Something I don't think we've done before.

Let me know.

Comment 4

[:shell escalante]

Hi Cory,

Sorry for not giving full details.  The whole feature Hello is turned off in the 38.0 ESR version of Firefox.  So the request is to turn off any Hello portion of the first run tour for ESR 38.0.

We couldn't support the Hello in the ESR 38.0 version as we knew there were breaking changes coming in releases that wouldn't be backward compatible.

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> We should probably disable the firstrun for esr. It would be easier and
> faster.
Could we go with this plan?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Yes, works for me.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Cory, do you have an eta for this? Thanks

Comment 8

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Sylvestre Ledru [:sylvestre] -- PTO May 9=>16 from comment #7)
> Cory, do you have an eta for this? Thanks
Ha! I was under the impression this is something releng would take care of. Possibly here? https://dxr.mozilla.org/mozilla-central/source/browser/branding/official/pref/firefox-branding.js

I don't think we've turned off /firstrun on the web before.

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Adding Lawrence here, since Sylvestre is on PTO. Note that the ESR 38.0 build has been now fully tested, and ready for release pending on resolving this issue.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Hal - Is first run (see the URL in comment0) configured in balrog? If so, can you disable the first run page for ESR 38.x?

Comment 11

[hwine]

As discussed in #releng, firstrun is not a balrog controlled feature - it's a default pref.

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

I don't see how we can turn this off on the web without impacting Firefox 38. If that's possible, that's definitely the way to go.

Given that we need to ship ESR 38.0.1, it seems that we should disable firstrun and rebuild.

Gavin - Comment 8 looks to contain the correct pref. Can you confirm?

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Also, can we just clear the pref? Do we need to disable firstrun somewhere else?

Corey - If we specify an alternate, ESR specific URL, can you easily post the firstrun tour without step 2: Hello? i.e. Is it easy to remove only the Hello portion of the firstrun tour?

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Gavin confirmed on irc that to kill firstrun on ESR38 we should just clear the pref at https://hg.mozilla.org/releases/mozilla-esr38/file/0ad83e09db9d/browser/branding/official/pref/firefox-branding.js#l6

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Attachment: Patch to disable firstrun for ESR38

Comment 16

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8605641 [details] [diff] [review]
Patch to disable firstrun for ESR38

Looks like I altered the line ending on the last line of the file accidentally. Perhaps my Hg configuration isn't correct.

Comment 17

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #13)
> Also, can we just clear the pref? Do we need to disable firstrun somewhere
> else?
> 
> Corey - If we specify an alternate, ESR specific URL, can you easily post
> the firstrun tour without step 2: Hello? i.e. Is it easy to remove only the
> Hello portion of the firstrun tour?
Given comment 14, is this question still valid?

I believe we can already detect whether or not a user is browsing in ESR.

I'd rather not try to reconfigure the tour around Hello if possible.

What about redirecting these users to the moz.org homepage as a workaround?

Comment 18

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Just found bug 1164440, and adding :kohei to this bug. Looks like the ability to detect ESR is currently in the works.

Comment 19

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Cory Price [:ckprice] from comment #18)
> Just found bug 1164440, and adding :kohei to this bug. Looks like the
> ability to detect ESR is currently in the works.

Bug 1164440 points to our solution for ESR31. We can put something like that in for ESR38 but without a good page to redirect ESR38 browsers to, it seems that our best option, given that we need to ship ESR 38.0.1, is still to disable firstrun for ESR38.

Comment 20

[Lawrence Mandel [:lmandel] (use needinfo)]

Note that this bug is needed on the ESR38 and ESR38 relbranch.

Comment 21

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8605641 [details] [diff] [review]
Patch to disable firstrun for ESR38

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: User confusion. Users will see Hello in the firstrun tour even though the feature isn't available in ESR38. 
Fix Landed on Version: This is a patch for ESR38 specifically. firstrun will remain enabled for mainline Firefox.
Risk to taking this patch (and alternatives if risky): Very low risk. This patch disables firstrun for ESR38 by removing the URL from the pref.
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 22

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

ESR38: https://hg.mozilla.org/releases/mozilla-esr38/rev/7877aef4f906
GECKO380esr_2015050513_RELBRANCH: https://hg.mozilla.org/releases/mozilla-esr38/rev/d0fb637e6902

Comment 23

[Lawrence Mandel [:lmandel] (use needinfo)]

This is included in ESR 38.0.1.

Comment 24

[Lawrence Mandel [:lmandel] (use needinfo)]

ashughes verified the fix in ESR 38.0.1 build2.