Closed Bug 1162147 Opened 9 years ago Closed 9 years ago

"View Pocket List" menuitem should be at top of bookmarks menu

Categories

(Firefox :: Pocket, defect, P4)

defect

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox38.0.5 --- verified
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: pdehaan, Assigned: Dolske)

References

Details

Attachments

(2 files, 4 obsolete files)

Attached image shorterfilename.png (obsolete) —
Per https://mozilla.aha.io/published/809d6d2e5fd193e0a8e833560fdb4fe0?page=10

In the UI spec (not sure if this is the latest one, we have lots of UI links floating around), but it shows the "Show Pocket List" at the top of the context menu.

In today's Nightly build the "View Pocket List" (note the verbiage slightly changed as well) link is between "Unsorted Bookmarks" and "Recently Bookmarked".

See attached screenshot.
Blocks: Pocket, 1155519
Flags: qe-verify+
The text is correct, but the placement should be up at the top; underneath the bookmarks sidebar item.
(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #2)
> The text is correct, but the placement should be up at the top

Why?
(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> (In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #2)
> > The text is correct, but the placement should be up at the top
> 
> Why?

Why is it in the middle now?  The original placement with the old reading list was also a popup menu so it fit well within the other items in the list.  This won't be a popout menu like those others, Pocket isn't interested in that.  Now its the only item in that section of the list that isn't a pop out menu.  The top of list is a bunch of actions similar to this open action so I think the placement there makes more sense than the middle.
That makes sense to me.
Summary: "View Pocket List" link in bookmarks menu doesn't match UI spec → "View Pocket List" menuitem should be at top of bookmarks menu
Attached patch Patch v.1 (obsolete) — Splinter Review
This moves it to the top, although looking at it I'm not sure if we really want it there or in the 2nd position (ie, after Show All Bookmarks). And I'm not sure exactly what we want for the bookmark-button menupanel; there's a View Bookmark Sidebar entry at the top, and seems like the Pocket & Show All Bookmarks items should be grouped together.
Assignee: nobody → dolske
Flags: needinfo?(madhava)
Hmm, really should be asking Michael instead. Sorry, madhava is still my reflexive UX NI. ;)
Flags: needinfo?(madhava) → needinfo?(mmaslaney)
Can we move it below show all bookmarks, but with it's own section like the "subscribe to this page" menu item?
Flags: needinfo?(mmaslaney)
Attached patch Patch v.2Splinter Review
Updated to position it just below Show All Bookmarks, in its own section.
Attachment #8602920 - Attachment is obsolete: true
Attachment #8602921 - Attachment is obsolete: true
Attachment #8602922 - Attachment is obsolete: true
Attachment #8602936 - Flags: review?(jaws)
Attached image Screenshot -- patch v.2
Attachment #8602212 - Attachment description: Aha____The_new_way_to_create_brilliant_product_roadmaps_and_1162136_–_Missing_Pocket_icon_on__Save_Page_to_Pocket__context_menu_item_and_Submit_Your_Feedback____Firefox_Input.png → shorterfilename.png
Attachment #8602212 - Attachment is obsolete: true
Attachment #8602936 - Flags: review?(jaws) → review+
I'm not seeing the bookmarks menu item redirecting me to getpocket.com in today's Nightly build.
Do we have a tracking bug for that, or should I file one?
(In reply to Peter deHaan [:pdehaan] from comment #13)
> I'm not seeing the bookmarks menu item redirecting me to getpocket.com in
> today's Nightly build.
> Do we have a tracking bug for that, or should I file one?

That is bug 1162735, which a fix for was just pushed to fx-team.
Priority: -- → P4
QA Contact: andrei.vaida
Comment on attachment 8602936 [details] [diff] [review]
Patch v.2

[Triage Comment]

Required for Pocket / 38.0.5 release.
Attachment #8602936 - Flags: approval-mozilla-release+
Attachment #8602936 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/dd2a9bc4915f
https://hg.mozilla.org/releases/mozilla-release/rev/740f3d68a0f6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
According to the Attached images, the 'show bookmarks sidebar' was ditched with this change ?
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #18)
> According to the Attached images, the 'show bookmarks sidebar' was ditched
> with this change ?


Nevermind, just grabbed latest m-c win32 Tinderbox Hourly build, and its still there....
Iteration: --- → 40.3 - 11 May
Flags: firefox-backlog+
Verified as fixed using the following environment:

FF 38.05
Build Id: 20150510205200
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x86
When testing I found an issue with "View Pocket List" menuitem if the bookmarks button is moved to Menu Bar.
I've logged the issue on bug 1163655
Depends on: 1163655
Removing qe-verify flag as verification Firefox 38.0.5 should suffice.
Flags: qe-verify+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.