1163655 - View Pocket List menuitem is not at top if Bookmarks button is moved to menu panel.

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P4)

Description

[Catalin Varga [QA][:VarCat]]

Attachment: pocket list.jpg

Environment:

F 38.0.5
OS: Win 7 x64, Mac OS X 10.9.5

STR:

1. Start Firefox.
2. Press Menu Bar -> Customize
3. Move Bookmarks button from toolbar to Menu Panel exit Customize.
4. Press Bookmarks button from Menu Panel

Issue:
View Pocket List menuitem is not correctly positioned, is at the middle instead of at the top. I've attached a printscreen of the issue

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: bz://1163655/Gijs

/r/8835 - Bug 1163655 - move pocket item further up in the bookmarks view, r?florian

Pull down this commit:

hg pull -r ceeefdb4d97ce7b082ebbf1139817c0229b0d0dd https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[:Gijs (he/him)]

... or wontfix, I'm not fussed either way. Dunno how important we think this placement is.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8606324 [details]
MozReview Request: bz://1163655/Gijs

https://reviewboard.mozilla.org/r/8833/#review7591

The code change is fine, but I think this has very little user impact, so I'm equally happy with a wontfix, especially as it's getting late for 38.0.5.

Comment 4

[:Gijs (he/him)]

(In reply to Florian Quèze [:florian] [:flo] (PTO until May 18th) from comment #3)
> Comment on attachment 8606324 [details]
> MozReview Request: bz://1163655/Gijs
> 
> https://reviewboard.mozilla.org/r/8833/#review7591
> 
> The code change is fine, but I think this has very little user impact, so
> I'm equally happy with a wontfix, especially as it's getting late for 38.0.5.

Dolske?

Comment 5

[Justin Dolske [:Dolske]]

I think we should fix this, but it isn't critical for 38.0.5. Given that, I think we shouldn't uplift this for the RC build. (Uplift to 39 would be good though.)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9defb2f73316

Comment 7

[:Gijs (he/him)]

Comment on attachment 8606324 [details]
MozReview Request: bz://1163655/Gijs

Approval Request Comment
[Feature/regressing bug #]: pocket
[User impact if declined]: hard to find pocket in the bookmarks view when it's in the panel
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low / none, just moving an existing item along in an existing menu
[String/UUID change made/needed]: nope

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9defb2f73316

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8606324 [details]
MozReview Request: bz://1163655/Gijs

Approved for uplift to aurora and beta. Minor UI fix for Pocket.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/839f81d4aab4

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/85da196ff50d

Comment 12

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 38.0.5 Beta 1 using Windows 7 64-bit.

Verified fixed on Firefox 39 Beta 1 (20150523155636), Firefox 40.0a2 (2015-05-26/27) and 41.0a1 (2015-05-26) using Ubuntu 14.04 32-bit, Mac OS X 10.9.5 and Windows 7 64-bit.

Comment 14

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1163655 - move pocket item further up in the bookmarks view, r?florian