Closed Bug 1163655 Opened 5 years ago Closed 5 years ago

View Pocket List menuitem is not at top if Bookmarks button is moved to menu panel.

Categories

(Firefox :: Pocket, defect, P4)

38 Branch
defect
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
41.1 - May 25
Tracking Status
firefox39 --- verified
firefox40 --- verified
firefox41 --- verified

People

(Reporter: VarCat, Assigned: Gijs)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image pocket list.jpg
Environment:

F 38.0.5
OS: Win 7 x64, Mac OS X 10.9.5

STR:

1. Start Firefox.
2. Press Menu Bar -> Customize
3. Move Bookmarks button from toolbar to Menu Panel exit Customize.
4. Press Bookmarks button from Menu Panel

Issue:
View Pocket List menuitem is not correctly positioned, is at the middle instead of at the top. I've attached a printscreen of the issue
Blocks: 1162147
Attached file MozReview Request: bz://1163655/Gijs (obsolete) —
/r/8835 - Bug 1163655 - move pocket item further up in the bookmarks view, r?florian

Pull down this commit:

hg pull -r ceeefdb4d97ce7b082ebbf1139817c0229b0d0dd https://reviewboard-hg.mozilla.org/gecko/
Attachment #8606324 - Flags: review?(florian)
... or wontfix, I'm not fussed either way. Dunno how important we think this placement is.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 41.1 - May 25
Points: --- → 1
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Priority: -- → P4
Attachment #8606324 - Flags: review?(florian) → review+
Comment on attachment 8606324 [details]
MozReview Request: bz://1163655/Gijs

https://reviewboard.mozilla.org/r/8833/#review7591

The code change is fine, but I think this has very little user impact, so I'm equally happy with a wontfix, especially as it's getting late for 38.0.5.
(In reply to Florian Quèze [:florian] [:flo] (PTO until May 18th) from comment #3)
> Comment on attachment 8606324 [details]
> MozReview Request: bz://1163655/Gijs
> 
> https://reviewboard.mozilla.org/r/8833/#review7591
> 
> The code change is fine, but I think this has very little user impact, so
> I'm equally happy with a wontfix, especially as it's getting late for 38.0.5.

Dolske?
Flags: needinfo?(dolske)
I think we should fix this, but it isn't critical for 38.0.5. Given that, I think we shouldn't uplift this for the RC build. (Uplift to 39 would be good though.)
Flags: needinfo?(dolske)
Comment on attachment 8606324 [details]
MozReview Request: bz://1163655/Gijs

Approval Request Comment
[Feature/regressing bug #]: pocket
[User impact if declined]: hard to find pocket in the bookmarks view when it's in the panel
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low / none, just moving an existing item along in an existing menu
[String/UUID change made/needed]: nope
Attachment #8606324 - Flags: approval-mozilla-beta?
Attachment #8606324 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9defb2f73316
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8606324 [details]
MozReview Request: bz://1163655/Gijs

Approved for uplift to aurora and beta. Minor UI fix for Pocket.
Attachment #8606324 - Flags: approval-mozilla-beta?
Attachment #8606324 - Flags: approval-mozilla-beta+
Attachment #8606324 - Flags: approval-mozilla-aurora?
Attachment #8606324 - Flags: approval-mozilla-aurora+
I was able to reproduce this issue on Firefox 38.0.5 Beta 1 using Windows 7 64-bit.

Verified fixed on Firefox 39 Beta 1 (20150523155636), Firefox 40.0a2 (2015-05-26/27) and 41.0a1 (2015-05-26) using Ubuntu 14.04 32-bit, Mac OS X 10.9.5 and Windows 7 64-bit.
Attachment #8606324 - Attachment is obsolete: true
Attachment #8620266 - Flags: review+
You need to log in before you can comment on or make changes to this bug.