Closed Bug 1163655 Opened 5 years ago Closed 5 years ago
View Pocket List menuitem is not at top if Bookmarks button is moved to menu panel
Environment: F 38.0.5 OS: Win 7 x64, Mac OS X 10.9.5 STR: 1. Start Firefox. 2. Press Menu Bar -> Customize 3. Move Bookmarks button from toolbar to Menu Panel exit Customize. 4. Press Bookmarks button from Menu Panel Issue: View Pocket List menuitem is not correctly positioned, is at the middle instead of at the top. I've attached a printscreen of the issue
/r/8835 - Bug 1163655 - move pocket item further up in the bookmarks view, r?florian Pull down this commit: hg pull -r ceeefdb4d97ce7b082ebbf1139817c0229b0d0dd https://reviewboard-hg.mozilla.org/gecko/
Attachment #8606324 - Flags: review?(florian)
... or wontfix, I'm not fussed either way. Dunno how important we think this placement is.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 41.1 - May 25
Points: --- → 1
Attachment #8606324 - Flags: review?(florian) → review+
Comment on attachment 8606324 [details] MozReview Request: bz://1163655/Gijs https://reviewboard.mozilla.org/r/8833/#review7591 The code change is fine, but I think this has very little user impact, so I'm equally happy with a wontfix, especially as it's getting late for 38.0.5.
(In reply to Florian Quèze [:florian] [:flo] (PTO until May 18th) from comment #3) > Comment on attachment 8606324 [details] > MozReview Request: bz://1163655/Gijs > > https://reviewboard.mozilla.org/r/8833/#review7591 > > The code change is fine, but I think this has very little user impact, so > I'm equally happy with a wontfix, especially as it's getting late for 38.0.5. Dolske?
I think we should fix this, but it isn't critical for 38.0.5. Given that, I think we shouldn't uplift this for the RC build. (Uplift to 39 would be good though.)
Comment on attachment 8606324 [details] MozReview Request: bz://1163655/Gijs Approval Request Comment [Feature/regressing bug #]: pocket [User impact if declined]: hard to find pocket in the bookmarks view when it's in the panel [Describe test coverage new/current, TreeHerder]: nope [Risks and why]: very low / none, just moving an existing item along in an existing menu [String/UUID change made/needed]: nope
Comment on attachment 8606324 [details] MozReview Request: bz://1163655/Gijs Approved for uplift to aurora and beta. Minor UI fix for Pocket.
I was able to reproduce this issue on Firefox 38.0.5 Beta 1 using Windows 7 64-bit. Verified fixed on Firefox 39 Beta 1 (20150523155636), Firefox 40.0a2 (2015-05-26/27) and 41.0a1 (2015-05-26) using Ubuntu 14.04 32-bit, Mac OS X 10.9.5 and Windows 7 64-bit.
You need to log in before you can comment on or make changes to this bug.