Closed
Bug 1162629
Opened 10 years ago
Closed 10 years ago
Remote Tabs Home Panel needs a 'no tabs' state
Categories
(Firefox for iOS :: Sync, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1171599
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: st3fan, Assigned: st3fan)
References
Details
Attachments
(1 file)
See attached screenshot. It is possible that we have a client record, but no synced tabs for that client.
We can not show that device at all. Which means there is a possibility that the complete list is empty. So we need some 'no devices have synced their tabs' state.
Or we can show a single row under the device with some 'no synced tabs' message.
|
||
Updated•10 years ago
|
tracking-fennec: ? → +
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → sarentz
|
|
Assignee | |
Comment 3•10 years ago
|
||
First iteration to get this bug going. This patch simply filters out clients with no tabs. If there are no clients at all then the home panel shows the (unimplemented) empty state.
Attachment #8604847 -
Flags: review?(sleroux)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8604847 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/455
First iteration looks good just super minor nit comment
Attachment #8604847 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Nit fixed!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•10 years ago
|
||
We need a state where you have no devices at all or no devices with tabs.
Robin, what do you think?
Status: RESOLVED → REOPENED
Flags: needinfo?(randersen)
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•10 years ago
|
||
Robin, how about we use the same empty states here that we have for the Send Tab extension? We cover two cases there: "Not logged in to FxA" and "No other devices".
|
|
Assignee | |
Updated•10 years ago
|
Status: REOPENED → NEW
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
Summary: Sync Tabs Panel needs a 'no tabs' state → Remote Tabs Home Panel needs a 'no tabs' state
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 9•10 years ago
|
||
The no tabs state (and 'sync error' and 'no clients') has been implemented as part of bug 1171599
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•