Closed Bug 1162752 Opened 9 years ago Closed 9 years ago

Exit from DOM fullscreen to fullscreen mode cause toolbar automatically collapse on OS X

Categories

(Firefox :: General, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 41
Tracking Status
firefox38 --- unaffected
firefox38.0.5 --- unaffected
firefox39 --- unaffected
firefox40 --- verified
firefox41 --- verified

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

The fullscreen mode on OS X >= 10.7 normally does not hide the toolbar. But after bug 947854, there is a regression that when returning from DOM fullscreen to fullscreen mode, the toolbar will automatically hide.

I'll look into it this weekend. It should be fixed in Firefox 40 anyway. I don't want it to become a regression.
Attached patch patchSplinter Review
Attachment #8603628 - Flags: review?(dao)
Attachment #8603628 - Flags: review?(dao) → review+
Comment on attachment 8603628 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 947854
[User impact if declined]: on OS X >= 10.7, the toolbar will be unexpectedly hidden when exit from DOM fullscreen to fullscreen mode
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: pretty low risk since the code changed affects only Mac, and the logic here looks simple
[String/UUID change made/needed]: n/a
Attachment #8603628 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d11b9d29d909
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Depends on: 1165570
Comment on attachment 8603628 [details] [diff] [review]
patch

Recent regression, taking it.
Attachment #8603628 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1168397
Verified as fixed using Firefox 40 beta 2 and latest Aurora 41.0a2 2015-07-08 under Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.