1165570 - Native fullscreen button is still displayed even in fullscreen mode on toolbar

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

On Mac OS X, after entering fullscreen mode, the fullscreen button is still displayed on the toolbar. It should be hidden since the system provides such button for exiting on the top menu bar.

This is a regression from bug 1162752.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8607845 [details] [diff] [review]
patch

>+    // For Lion fullscreen, all fullscreen controls are hidden, don't
>+    // bother to touch them. If we don't stop here, the following code
>+    // could cause the native fullscreen button be shown unexpectedly.
>+    // See bug 1165570.
>+    if (!aShow && this.useLionFullScreen) {
>+      return;
>+    }

Why do you care about !aShow here?

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

I guess it doesn't really matter... When I was debugging bug 1105939, I suspected a bug was potentially related to this, which later was proven to be false. Hence it seems to me that either version is fine. If you think the old one is better, you could obsolete the new one and grant the old one :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1bc7f9b2e95c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1bc7f9b2e95c

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8606774 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1162752
[User impact if declined]: will see fullscreen button on tabbar even in fullscreen mode
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: shouldn't be risky
[String/UUID change made/needed]: n/a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/85e2691eb2ec