1162914 - Editing a user field when confirmuniqueusermatch = true no longer works

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

This is a regression in 5.0. It's working fine in 4.4.9. When the confirmuniqueusermatch parameter is set to true, and you type a partial user name in a user field of a bug (either CC list, or assignee/QA contact) and submit changes before waiting for the auto-completion list to appear, you get an intermediate page asking you to confirm the assignee/QA contact/CC'ed user, as expected. But when you click "Continue", nothing happens, the user field is left unchanged. If you turn off this parameter, it works fine.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

The template was using the 'cgi' variable, but this variable was not defined in this template. The code worked till now because 'cgi' was defined in another template, probably global/header.html.tmpl or some other widely used template, and so this variable was always defined. When doing the move to HTML5, I removed some unused variables which were not used directly in the templates in which they were defined, which triggered this bug. It's a really bad policy to assume that a variable you need is defined elsewhere, unless the INTERFACE says the variable is passed by the caller, and so it's actually a good thing that my cleanup triggered this bug.

Comment 2

[Frédéric Buclin]

Actually, the "bad" code was inserted by bug 756314 (Bugzilla 4.0). The 'cgi' variable was used, but not defined.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8603480 [details] [diff] [review]
patch, v1

Review of attachment 8603480 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 4

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   4779266..ccda2ce  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   f1b2372..e191f86  5.0 -> 5.0