1163105 - SVG filters not being applied on off-screen canvases

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Tobias Schneider [:tobytailor]]

Attachment: test case

When referencing SVG filters via `url(#someFilter)` in off-screen canvases, no filter effects get applied.

Comment 1

[Chris Peterson [:cpeterson]]

Jet will follow up with mstange.

Comment 2

[Jet Villegas (inactive)]

mstange says this used to work. He's looking into it.

Comment 3

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8612634 [details]
MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

https://reviewboard.mozilla.org/r/9615/#review9155

Needs a test!

Comment 5

[Markus Stange [:mstange]]

This patch doesn't actually fix the bug.

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8612634 [details]
MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

Comment 7

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1163105 - Flush frames before building the filter. r=roc

Bug 1163105 - Flush frames before building the filter. r=roc

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8612634 [details]
MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

https://reviewboard.mozilla.org/r/9615/#review9353

Ship It!

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8617633 [details]
MozReview Request: Bug 1163105 - Flush frames before building the filter. r=roc

https://reviewboard.mozilla.org/r/10649/#review9355

Looks good. Still hoping for a test :-)

Comment 10

[Markus Stange [:mstange]]

You'll get one :-)
There is one in Tobias' test patch in bug 927892 comment 58.

Comment 11

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59e52c9cff43
https://hg.mozilla.org/integration/mozilla-inbound/rev/50c97a5a683a

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/59e52c9cff43
https://hg.mozilla.org/mozilla-central/rev/50c97a5a683a