SVG filters not being applied on off-screen canvases

RESOLVED FIXED in Firefox 41

Status

()

Core
Canvas: 2D
RESOLVED FIXED
3 years ago
10 months ago

People

(Reporter: tobytailor, Assigned: mstange)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8603496 [details]
test case

When referencing SVG filters via `url(#someFilter)` in off-screen canvases, no filter effects get applied.
(Reporter)

Updated

3 years ago
Blocks: 927892
Jet will follow up with mstange.
Assignee: nobody → bugs
Blocks: 1037568

Comment 2

3 years ago
mstange says this used to work. He's looking into it.
Assignee: bugs → mstange
(Assignee)

Comment 3

3 years ago
Created attachment 8612634 [details]
MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc
Attachment #8612634 - Flags: review?(roc)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
Comment on attachment 8612634 [details]
MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

https://reviewboard.mozilla.org/r/9615/#review9155

Needs a test!
Attachment #8612634 - Flags: review?(roc) → review+
(Assignee)

Comment 5

3 years ago
This patch doesn't actually fix the bug.
(Assignee)

Updated

3 years ago
Attachment #8612634 - Flags: review+
(Assignee)

Comment 6

3 years ago
Comment on attachment 8612634 [details]
MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc
(Assignee)

Comment 7

3 years ago
Created attachment 8617633 [details]
MozReview Request: Bug 1163105 - Flush frames before building the filter. r=roc

Bug 1163105 - Flush frames before building the filter. r=roc
Attachment #8617633 - Flags: review?(roc)
Comment on attachment 8612634 [details]
MozReview Request: Bug 1163105 - Make nsReferencedElement work with referencing elements that are not in their document's DOM tree. r=roc

https://reviewboard.mozilla.org/r/9615/#review9353

Ship It!
Attachment #8612634 - Flags: review+
Comment on attachment 8617633 [details]
MozReview Request: Bug 1163105 - Flush frames before building the filter. r=roc

https://reviewboard.mozilla.org/r/10649/#review9355

Looks good. Still hoping for a test :-)
Attachment #8617633 - Flags: review?(roc) → review+
(Assignee)

Comment 10

3 years ago
You'll get one :-)
There is one in Tobias' test patch in bug 927892 comment 58.
(Assignee)

Updated

3 years ago
Blocks: 1173545
No longer blocks: 927892
https://hg.mozilla.org/mozilla-central/rev/59e52c9cff43
https://hg.mozilla.org/mozilla-central/rev/50c97a5a683a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

Updated

10 months ago
Depends on: 1352295
You need to log in before you can comment on or make changes to this bug.