1173545 - Enable canvas CSS/SVG filters by default

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Markus Stange [:mstange]]

This bug tracks the work that needs to be done before we can set the pref canvas.filters.enabled to true by default.

Comment 1

[Florian Scholz (Open Web Docs)]

This is now enabled by default in Chrome 52
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Jhwj8QAYaFY
https://www.chromestatus.com/features/6701649301078016

Comment 2

[Tobias Schneider [:tobytailor]]

Attachment: Flip canvas.filters.enabled pref

Turn on the lights!

Comment 3

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=33c6e86e558d

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8758384 [details] [diff] [review]
Flip canvas.filters.enabled pref

Review of attachment 8758384 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 5

[Marcia Knous [:marcia]]

Markus/Tobias - Do you want to land this on mozcentral and then nominate it to be release noted?

Comment 6

[Tobias Schneider [:tobytailor]]

Yes!

Comment 7

[Tobias Schneider [:tobytailor]]

New try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bee9a727d4a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/daf8583252b2
Enable canvas CSS/SVG filters by default. r=mstange

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/daf8583252b2

Comment 10

[Florian Scholz (Open Web Docs)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Dev-docs:
https://developer.mozilla.org/en-US/Firefox/Releases/49#Canvas
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/filter

Also adding relnote request as per comment 5:

Release Note Request (optional, but appreciated)
[Why is this notable]: CSS filters are now available to canvas as well
[Suggested wording]: The Canvas2D filter property has been implemented. It provides filter effects like blurring or gray-scaling similar to the CSS filter property.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/filter

Comment 11

[Sylvestre Ledru [:Sylvestre]]

I think that the note on MDN is enough. Please need info me if you disagree

Comment 12

[ishmael.ahmed]

I think this fix effect ctx.shadowBlur ?

Comment 13

[ishmael.ahmed]

I have been using a mixture of globalAlpha, shadowColor, and shadowBlur to blur text in my canvas elements. Since the release this technique is now failing, would the implementation of the blur filter be effecting it?

Comment 14

[Markus Stange [:mstange]]

It's possible that the interaction with the filter code has broken something. Can you please file a new bug and attach a minimal testcase?

Comment 15

[ishmael.ahmed]

Will do

Comment 16

[ishmael.ahmed]

I found Bug 1306027, and added a link to my example[https://jsfiddle.net/ishmael_readingplus/hag1tc99/] there.