Enable canvas CSS/SVG filters by default

RESOLVED FIXED in Firefox 49

Status

()

defect
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

({dev-doc-complete})

Trunk
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(platform-rel +, firefox41 affected, firefox49 fixed, relnote-firefox -)

Details

(Whiteboard: [parity-blink][platform-rel-Google][platform-rel-GoogleDocs])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This bug tracks the work that needs to be done before we can set the pref canvas.filters.enabled to true by default.
(Assignee)

Updated

4 years ago
Depends on: 1163124
(Assignee)

Updated

4 years ago
Depends on: 1163105
(Assignee)

Updated

4 years ago
Depends on: 1174278
(Assignee)

Updated

4 years ago
Depends on: 1195968
Depends on: 1163107
Depends on: 1262745
Attachment #8758384 - Flags: review?(mstange)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8758384 [details] [diff] [review]
Flip canvas.filters.enabled pref

Review of attachment 8758384 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8758384 - Flags: review?(mstange) → review+
Markus/Tobias - Do you want to land this on mozcentral and then nominate it to be release noted?
Flags: needinfo?(tschneider)
Flags: needinfo?(mstange)
Yes!
Flags: needinfo?(tschneider)

Comment 8

3 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/daf8583252b2
Enable canvas CSS/SVG filters by default. r=mstange
Keywords: checkin-needed

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/daf8583252b2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
(Assignee)

Updated

3 years ago
Flags: needinfo?(mstange)
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Dev-docs:
https://developer.mozilla.org/en-US/Firefox/Releases/49#Canvas
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/filter

Also adding relnote request as per comment 5:

Release Note Request (optional, but appreciated)
[Why is this notable]: CSS filters are now available to canvas as well
[Suggested wording]: The Canvas2D filter property has been implemented. It provides filter effects like blurring or gray-scaling similar to the CSS filter property.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/filter
platform-rel: --- → +
Whiteboard: [parity-blink] → [parity-blink][platform-rel-Google][platform-rel-GoogleDocs]
I think that the note on MDN is enough. Please need info me if you disagree
Depends on: CVE-2016-9077

Comment 12

3 years ago
I think this fix effect ctx.shadowBlur ?

Comment 13

3 years ago
I have been using a mixture of globalAlpha, shadowColor, and shadowBlur to blur text in my canvas elements. Since the release this technique is now failing, would the implementation of the blur filter be effecting it?
(Assignee)

Comment 14

3 years ago
It's possible that the interaction with the filter code has broken something. Can you please file a new bug and attach a minimal testcase?

Comment 15

3 years ago
Will do

Comment 16

3 years ago
I found Bug 1306027, and added a link to my example[https://jsfiddle.net/ishmael_readingplus/hag1tc99/] there.

Updated

3 years ago
Depends on: 1307740
You need to log in before you can comment on or make changes to this bug.