1163197 - Show compatibility error if an add-on uses lightweightThemes.usedThemes or lightweightThemes.isThemeSelected

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 1094821, there were some changes on how theme selection is stored, changing the meaning of the preferences used for this. All instances of the preferences "lightweightThemes.usedThemes" and "lightweightThemes.isThemeSelected" need to be flagged.

This is a compatibility error, so the add-on shouldn't be upgraded in this case. It should also appear as a warning in regular validations.

Message:

The preferences used to store theme selection have changed. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1094821#c39

Affected add-on:

https://addons.mozilla.org/addon/noia-fox-options/

Release timing:

Firefox 39 will be released on June 30th.

Comment 1

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/amo-validator/pull/288

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mstriemer/amo-validator/commit/148a2a50decabc5743abb6f0b4afe90d1f86d012

Comment 3

[Victor Carciu]

Can you please add some STRs to this bug or mark it as qa- ?