1163423 - Introduce JS_HasOwnProperty

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

Attachment: has-own

We already have JS_AlreayHasOwnProperty, but that function doesn't call resolve hooks. Maybe worth looking into if we can remove it.

Comment 1

[Tom S [:evilpie]]

Attachment: Use JS_HasOwnProperty in WrapperAnswer::RecvHasOwn

Comment 2

[Boris Zbarsky [:bzbarsky]]

> Maybe worth looking into if we can remove it.

So looking at consumers of JS_AlreadyHasOwnProperty(ById):

1)  DOMProxyShadows is using it on the expando, so could use JS_HasOwnPropertyById.  Assuming that's not slower, of course.

2)  In DefineConstructor, I'm not exactly sure why we need that check.  It might be possible to remove it, if we know that the global's resolve hook will always resolve the relevant properties before someone has a chance to redefine them.

3)  Plugin code, no idea.  But those objects _do_ have resolve hooks, so need to check carefully.

4)  XBL, pretty sure is working on objects with no resolve hooks only.

5)  Xrays, working with holder objects, which have no resolve hook.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7886e8be8fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/efef07486dde

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7886e8be8fb
https://hg.mozilla.org/mozilla-central/rev/efef07486dde