Closed Bug 1163582 Opened 9 years ago Closed 9 years ago

Remove a bunch of mozL10n.get's from System

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

[gaia] zbraniecki:1163582-remove-a-bunch-of-mozl10n-get-from-system > mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
      No description provided.
Comment on attachment 8604085 [details] [review]
[gaia] zbraniecki:1163582-remove-a-bunch-of-mozl10n-get-from-system > mozilla-b2g:master

Kevin, I caught your refector of some templates (bug 1163394) and noticed that they use mozL10n.get without being guarded by mozL10n.once|ready for l10n readiness.

I took a bite and refactored the code so that they are not needed anymore.

Can you review this follow up?
Attachment #8604085 - Flags: review?(kgrandon)
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
See Also: → 1105648
Comment on attachment 8604085 [details] [review]
[gaia] zbraniecki:1163582-remove-a-bunch-of-mozl10n-get-from-system > mozilla-b2g:master

This looks good to me. Thank you!
Attachment #8604085 - Flags: review?(kgrandon) → review+
(Please fix the failing unit tests and make sure you test that this works before landing if you haven't. Thanks!)
Of course :) fixed tests and tested on the device.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1020138
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
weird, sorry for spam
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: