Closed
Bug 1163645
Opened 9 years ago
Closed 9 years ago
Pocket only enabled on en-US, hard-coded locales aren't picked up
Categories
(Firefox :: Pocket, defect)
Tracking
()
RESOLVED
FIXED
Firefox 41
People
(Reporter: Pike, Assigned: Dolske)
References
Details
Attachments
(1 file)
632 bytes,
patch
|
adw
:
review+
Dolske
:
approval-mozilla-aurora+
Dolske
:
approval-mozilla-beta+
Dolske
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
the beta repository still has pref("browser.pocket.enabledLocales", "en-US"); so the localizations we landed aren't shown in the UI at this point. flod and Jeff verified with the 38.0.5 beta candidates from today.
Reporter | ||
Comment 1•9 years ago
|
||
[Tracking Requested - why for this release]:
status-firefox38.0.5:
--- → affected
tracking-firefox38.0.5:
--- → ?
Assignee | ||
Comment 2•9 years ago
|
||
Sigh. Yes, this got missed. I think we were assuming we'd have a Nightly to verify all the L10N stuff before enabling, but then we YOLO-landed everything to make the schedule. :( Patch is trivial, will take "what do we do for beta1" to a release-drivers thread.
Assignee | ||
Comment 3•9 years ago
|
||
Assignee: nobody → dolske
Attachment #8604168 -
Flags: review?(adw)
Updated•9 years ago
|
Attachment #8604168 -
Flags: review?(adw) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Landed on m-r for an immediate respin for 38.0.5 beta1, build2. https://hg.mozilla.org/releases/mozilla-release/rev/fff143cacb66
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/569d3999242d
Assignee | ||
Updated•9 years ago
|
status-firefox39:
--- → affected
status-firefox40:
--- → affected
Updated•9 years ago
|
QA Contact: andrei.vaida
Comment 6•9 years ago
|
||
Tested Spanish again, I have a Pocket button and strings localized in Spanish in the UI.
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/569d3999242d
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment 8•9 years ago
|
||
Verified that de, es-Es, ja and ru locales have Pocket enabled using Firefox 38.0.5 beta 1 build 2 under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5. Please note that ja locale doesn't have Pocket installed under Mac OSX, probably because the build here is named ja-JP-mac. Also under OS X, the elements in the Pocket drop-down for the ru build are not aligned. There is no icon for other locales.
Comment 9•9 years ago
|
||
Justin, can you please take a look at the above comment and let us know the next actions?
Flags: needinfo?(dolske)
Reporter | ||
Comment 10•9 years ago
|
||
Petruta, are bugs filed for those yet? Also, for ja-JP-mac, it'd be interesting to know if fixing browser.pocket.enabledLocales to include ja-JP-mac fixes the issue. I wonder if the pocket strings would need adjustments, too.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(dolske)
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8604168 [details] [diff] [review] Patch v.1 [Triage Comment] a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8604168 -
Flags: approval-mozilla-release+
Attachment #8604168 -
Flags: approval-mozilla-beta+
Attachment #8604168 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 12•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/dc92613a9ba6 (previously landed on m-r -- comment 4, not yet landed on m-a due to tree closure)
Comment 13•9 years ago
|
||
Marking as verified 38.0.5 version based on comment 8 and follow-up bug 1164407 and bug 1164419.
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•