1163645 - Pocket only enabled on en-US, hard-coded locales aren't picked up

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Axel Hecht [:Pike]]

the beta repository still has

pref("browser.pocket.enabledLocales", "en-US");

so the localizations we landed aren't shown in the UI at this point.

flod and Jeff verified with the 38.0.5 beta candidates from today.

Comment 1

[Axel Hecht [:Pike]]

[Tracking Requested - why for this release]:

Comment 2

[Justin Dolske [:Dolske]]

Sigh. Yes, this got missed. I think we were assuming we'd have a Nightly to verify all the L10N stuff before enabling, but then we YOLO-landed everything to make the schedule. :(

Patch is trivial, will take "what do we do for beta1" to a release-drivers thread.

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Comment 4

[Justin Dolske [:Dolske]]

Landed on m-r for an immediate respin for 38.0.5 beta1, build2. 

https://hg.mozilla.org/releases/mozilla-release/rev/fff143cacb66

Comment 5

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/integration/fx-team/rev/569d3999242d

Comment 6

[Francesco Lodolo [:flod]]

Tested Spanish again, I have a Pocket button and strings localized in Spanish in the UI.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/569d3999242d

Comment 8

[Petruta Horea [:phorea]]

Verified that de, es-Es, ja and ru locales have Pocket enabled using Firefox 38.0.5 beta 1 build 2 under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5.

Please note that ja locale doesn't have Pocket installed under Mac OSX, probably because the build here is named ja-JP-mac.
Also under OS X, the elements in the Pocket drop-down for the ru build are not aligned.

There is no icon for other locales.

Comment 9

[Petruta Horea [:phorea]]

Justin, can you please take a look at the above comment and let us know the next actions?

Comment 10

[Axel Hecht [:Pike]]

Petruta, are bugs filed for those yet?

Also, for ja-JP-mac, it'd be interesting to know if fixing browser.pocket.enabledLocales to include ja-JP-mac fixes the issue. I wonder if the pocket strings would need adjustments, too.

Comment 11

[Justin Dolske [:Dolske]]

Comment on attachment 8604168 [details] [diff] [review]
Patch v.1

[Triage Comment]

a+ for aurora/beta/release: required for Pocket launch in 38.0.5.

Comment 12

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dc92613a9ba6

(previously landed on m-r -- comment 4, not yet landed on m-a due to tree closure)

Comment 13

[Petruta Horea [:phorea]]

Marking as verified 38.0.5 version based on comment 8 and follow-up bug 1164407 and bug 1164419.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7039a9ff03f5