[e10s] The scrollbar for <select> appears on the left side with RTL interface

VERIFIED FIXED in Firefox 41

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: over68, Assigned: gw280)

Tracking

(Blocks 1 bug, {rtl})

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

4 years ago
The scrollbar for <select> appears on the left side with RTL interface.

Testcase https://dl.dropboxusercontent.com/u/95157096/85f61cf7/f4l5ag33qq.html

Screenshot https://dl.dropboxusercontent.com/u/95157096/85f61cf7/71piv4scj4.png

Comment 1

4 years ago
WFM. It's on the right with the latest Nightly and e10s enabled.

Are you running the latest nightly?

Comment 2

4 years ago
Ok, I guess I didn't enable RTL. How do you do that?
Reporter

Comment 3

4 years ago
(In reply to Loic from comment #1)
> WFM. It's on the right with the latest Nightly and e10s enabled.
> 
> Are you running the latest nightly?

Yes, I am running the latest nightly.
Reporter

Comment 4

4 years ago
(In reply to Loic from comment #2)
> Ok, I guess I didn't enable RTL. How do you do that?

Switch to the RTL interface:

1. Go to "about:config".
2. Create a string preference with name "intl.uidirection.en" and value "rtl".
(In reply to Loic from comment #2)
> Ok, I guess I didn't enable RTL. How do you do that?

You can also just use an l10n build of an rtl language.

I can confirm bug this using latest Nightly Hebrew build on Mac.
tracking-e10s: --- → ?
OS: Windows 7 → All
Hardware: x86_64 → All
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

4 years ago
Blocks: e10s
Component: Untriaged → Layout: Form Controls
Keywords: rtl
Product: Firefox → Core
Speaking to Ehsan, it seems there are two main points here:

1) The scrollbar should ideally be on the left in a RTL interface.
2) The scrollbar and the dropdown arrow on the select widget should be in alignment.

Ehsan's opinion is that having them in alignment outweighs having the scrollbar on the left, and so we could just revert back to the existing non-e10s behaviour (should be a fairly easy fix).

Maybe long term we want to actually do the right thing here though, and modify the widget, but that will likely be fairly involved.

Axel, what do you think we should do here? I think we should land a patch to move the scrollbar to the right as that should be fairly easy, then track fixing it properly, if that's what we decide it should look like.
Flags: needinfo?(l10n)
I'm not good in RTL beyond the point that I know people that are. CCing a bunch of folks.
Flags: needinfo?(l10n)
Reporter

Updated

4 years ago
Blocks: e10s-select
Assignee: nobody → gwright
Comment on attachment 8605988 [details] [diff] [review]
.0001-Bug-1164099-Always-ensure-the-scrollbar-is-on-the-ri.patch.swp

I think you've accidentally uploaded some kind of binary.
Attachment #8605988 - Flags: review?(mconley)
Comment on attachment 8606392 [details] [diff] [review]
0001-Bug-1164099-Always-ensure-the-scrollbar-is-on-the-ri.patch

This works well - thanks gw280!
Attachment #8606392 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/bc1f37d99d6d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
QA Whiteboard: [good first verify][verify in Nightly only]
I have successfully reproduced the bug in firefox Nightly 41.0a1(Build ID: 20150512030215) with windows 10 PRO N (64 bit) 

Verified as fixed with 43.0a1 as comment 0

Build ID: 20150821030204
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0

[testday-20150821]
Successfully reproduce this bug on Nightly 41.0a1 (2015-05-12) (Build ID: 20150512030215) with the instruction from comment 0 on Linux x64

This Bug is now verified as fixed on Latest Firefox Nightly 43.0a1 (2015-08-27) 

Build ID: 20150827030213
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

As it is also verified on Windows (Comment 14), Marking it as verified!
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify][verify in Nightly only] → [good first verify][verify in Nightly only][bugday-20150826]
You need to log in before you can comment on or make changes to this bug.