1164155 - crash in RuleHash::~RuleHash()

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[alex_mayorga]

This bug was filed from the Socorro interface and is 
report bp-a32dad14-9146-438b-8a50-3e1862150512.
=============================================================

Crashing Thread
Frame 	Module 	Signature 	Source
0 	xul.dll 	RuleHash::~RuleHash() 	layout/style/nsCSSRuleProcessor.cpp
1 	xul.dll 	RuleCascadeData::`scalar deleting destructor'(unsigned int) 	
2 	xul.dll 	nsCSSRuleProcessor::ClearRuleCascades() 	layout/style/nsCSSRuleProcessor.cpp
3 	xul.dll 	nsCSSRuleProcessor::~nsCSSRuleProcessor() 	layout/style/nsCSSRuleProcessor.cpp
4 	xul.dll 	nsCSSRuleProcessor::`scalar deleting destructor'(unsigned int) 	
5 	xul.dll 	mozilla::dom::Exception::DeleteCycleCollectable() 	dom/base/DOMException.cpp
6 	xul.dll 	SnowWhiteKiller::~SnowWhiteKiller() 	xpcom/base/nsCycleCollector.cpp
7 	xul.dll 	nsCycleCollector::ForgetSkippable(bool, bool) 	xpcom/base/nsCycleCollector.cpp
8 	xul.dll 	nsCycleCollector_forgetSkippable(bool, bool) 	xpcom/base/nsCycleCollector.cpp
9 	xul.dll 	FireForgetSkippable 	dom/base/nsJSEnvironment.cpp
10 	xul.dll 	CCTimerFired 	dom/base/nsJSEnvironment.cpp
11 	xul.dll 	nsTimerImpl::Fire() 	xpcom/threads/nsTimerImpl.cpp
12 	xul.dll 	nsTimerEvent::Run() 	xpcom/threads/nsTimerImpl.cpp
13 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp
14 	xul.dll 	mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp
15 	xul.dll 	mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp
16 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc
17 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc
18 	xul.dll 	nsBaseAppShell::Run() 	widget/nsBaseAppShell.cpp
19 	xul.dll 	nsAppShell::Run() 	widget/windows/nsAppShell.cpp
20 	xul.dll 	XRE_RunAppShell 	toolkit/xre/nsEmbedFunctions.cpp
21 	xul.dll 	mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp
22 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc
23 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc
24 	xul.dll 	XRE_InitChildProcess 	toolkit/xre/nsEmbedFunctions.cpp
25 	plugin-container.exe 	content_process_main(int, char** const) 	ipc/contentproc/plugin-container.cpp
26 	plugin-container.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp
27 	plugin-container.exe 	__tmainCRTStartup 	f:/dd/vctools/crt/crtw32/startup/crt0.c:255
28 	kernel32.dll 	BaseThreadInitThunk 	
29 	ntdll.dll 	RtlUserThreadStart

Comment 1

[Mats Palmgren (inactive)]

Alex, do you have STR or any information about what you we're doing when the crash occurred?

Comment 2

[alex_mayorga]

¡Hola Mats!

Unfortunately I don't quite recall STR.

Might it be a variant of https://bugzilla.mozilla.org/show_bug.cgi?id=1167902 ?

Comment 3

[Mats Palmgren (inactive)]

Yeah, that seems likely, thanks.

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to alex_mayorga from comment #2)
> ¡Hola Mats!
> 
> Unfortunately I don't quite recall STR.
> 
> Might it be a variant of
> https://bugzilla.mozilla.org/show_bug.cgi?id=1167902 ?

You closed that bug and wrote "I haven't seen this crash signature in a while on Nightly, let's hope it stays this way..."

Same for this bug?

Comment 5

[alex_mayorga]

¡Hola Wayne!

0 crashes in the past month per https://crash-stats.mozilla.com/report/list?product=Firefox&range_unit=days&range_value=28&signature=RuleHash%3A%3A~RuleHash%28%29

So I guess this one is solved now.

¡Gracias!

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Updating crash signature to reflect changes to signature generation made in bug 1269817 (although reports older than a week will not be reprocessed), and adding dependency to ShutDownKill metabug.

(These probably shouldn't all be separate bugs, but I'm not going to fix that up in a mass-change.)