1164390 - Signing of a version fails if one of its files is missing on the filesystem

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Mathieu Agopian [:magopian]]

STR:
1/ upload an add-on which has at least two files for one of its version
2/ make sure one of the files doesn't exist on the filesystem
3/ review the add-on and approve it

The file that is present on the filesystem should be signed, but it is not.

Example failure: http://sentry.dmz.phx1.mozilla.com/addons/addons-dev/group/27651/
https://addons-dev.allizom.org/en-US/developers/addon/gigi/versions/1526634 (the file for linux isn't there, and the other one isn't signed).

:kmag could you please explain how to achieve 2/? You said something about rejecting a version and re-uploading another file with the same version, but I couldn't manage to do that on my end.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/557

Comment 2

[Kris Maglione [:kmag]]

In the case we came across on dev, it was the following:

1) Upload a new version of an add-on.
2) Reject or otherwise disable that version.
3) Upload a new version with the same version number.
4) Approve the new version.

At this point, the file with the same generated name as in the previous version is not available.

See bug 1130585 for reference.

Comment 3

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/d3745a160622cebbf6051ac88dee063d10d89b2e