Closed
Bug 1164447
Opened 9 years ago
Closed 9 years ago
Closure compiler removes ShumwayCom.reportTelemetry call
Categories
(Firefox Graveyard :: Shumway, defect)
Firefox Graveyard
Shumway
Tracking
(firefox41 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox41 | --- | affected |
People
(Reporter: yury, Assigned: tschneider)
References
Details
The code at https://github.com/mozilla/shumway/blob/62270bd4f602509bb74add9eb9f89967f3dc9d54/src/player/external.ts#L138 : export class ShumwayComTelemetryService implements ITelemetryService { reportTelemetry(data: any): void { ShumwayCom.reportTelemetry(data); } } Transformed into (see line 51529 at https://raw.githubusercontent.com/mozilla/shumway-dist/57e702af8f59d3a89dc5c8ed238457f55e1bfb12/build/bundles/shumway.player.js): g = function() { function b() { } b.prototype.reportTelemetry = function(b) { }; return b; }(); b.ShumwayComTelemetryService = g;
Updated•9 years ago
|
Blocks: shumway-m4
Comment 1•9 years ago
|
||
We definitely want to have telemetry working before landing on Nightly. Yury, is this fixed? I vaguely remember something about that.
Flags: needinfo?(ydelendik)
Reporter | ||
Comment 2•9 years ago
|
||
There issue is not fixed (and there is still a risk something else can be removed), however I introduced in the master `arguments.length;` statement in the function as workaround to prevent code from its removal.
Flags: needinfo?(ydelendik)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → schneider
Assignee | ||
Comment 3•9 years ago
|
||
Fixed in https://github.com/mozilla/shumway/pull/2319.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•