1164447 - Closure compiler removes ShumwayCom.reportTelemetry call

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

The code at https://github.com/mozilla/shumway/blob/62270bd4f602509bb74add9eb9f89967f3dc9d54/src/player/external.ts#L138 :

  export class ShumwayComTelemetryService implements ITelemetryService {
    reportTelemetry(data: any): void {
      ShumwayCom.reportTelemetry(data);
    }
  }

Transformed into (see line 51529 at https://raw.githubusercontent.com/mozilla/shumway-dist/57e702af8f59d3a89dc5c8ed238457f55e1bfb12/build/bundles/shumway.player.js):

    g = function() {
      function b() {
      }
      b.prototype.reportTelemetry = function(b) {
      };
      return b;
    }();
    b.ShumwayComTelemetryService = g;

Comment 1

[Till Schneidereit [:till]]

We definitely want to have telemetry working before landing on Nightly. Yury, is this fixed? I vaguely remember something about that.

Comment 2

[Yury Delendik (:yury)]

There issue is not fixed (and there is still a risk something else can be removed), however I introduced in the master `arguments.length;` statement in the function as workaround to prevent code from its removal.

Comment 3

[Tobias Schneider [:tobytailor]]

Fixed in https://github.com/mozilla/shumway/pull/2319.