Closed
Bug 1164556
Opened 9 years ago
Closed 9 years ago
Remove usage of |#ifdef PR_LOGGING| from toolkit
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files)
18.69 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.46 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Assignee | ||
Comment 1•9 years ago
|
||
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8605415 -
Flags: review?(nfroyd)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Remove what appears to be leftover debug code bypassing and if condition.
Attachment #8605417 -
Flags: review?(gpascutto)
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a5d07dc4d3d
Updated•9 years ago
|
Attachment #8605417 -
Flags: review?(gpascutto) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e44150fdc4a
Updated•9 years ago
|
Attachment #8605415 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb89e977bd5f https://hg.mozilla.org/integration/mozilla-inbound/rev/8e4f5e85d08c
https://hg.mozilla.org/mozilla-central/rev/bb89e977bd5f https://hg.mozilla.org/mozilla-central/rev/8e4f5e85d08c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•