1164623 - use standard TC environment variable parameters for desktop/android builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

The desktop/android build scripts have a nice set of input variables:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ce42ea552a#l3.9

but those differ in spelling, etc. from variables typically used for B2G builds.  We should resolve those differences to avoid confusion.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Also cache locations; see testing/taskcluster/tasks/builds/*.yml

For example:
  tooltool-cache: '/home/worker/tools/tooltool-cache

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Cache locations shouldn't be specified in the task, so that's not necessary.

However, B2G seems to use
      MOZHARNESS_REPOSITORY: '{{mozharness_repository}}'
      MOZHARNESS_REV: '{{mozharness_rev}}'
      MOZHARNESS_REF: '{{mozharness_ref}}'
while the desktop script uses
      MOZHARNESS_BASE_REPOSITORY: '{{mozharness_repository}}'
      MOZHARNESS_HEAD_REPOSITORY: '{{mozharness_repository}}'
      MOZHARNESS_REV: '{{mozharness_rev}}'

and similarly
      GECKO_HEAD_REV: '{{head_rev}}'
      GECKO_HEAD_REF: '{{head_ref}}'
vs
      GECKO_REV: '{{head_rev}}'

B2G uses "MOZCONFIG", but that's irrelevant for us since mozharness specifies the mozconfig.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: bz://1164623/dustin

/r/9455 - Bug 1164623: align env variable names with B2G; r=mrrrgn

Pull down this commit:

hg pull -r 42aaec27266eae2bf2a502e648687036697109ab https://reviewboard-hg.mozilla.org/gecko/

Comment 4

[Morgan Phillips [:mrrrgn]]

https://reviewboard.mozilla.org/r/9455/#review8205

::: testing/docker/desktop-build/bin/build.sh
(Diff revision 1)
> -: TOOLS_BASE_REPOSITORY         ${TOOLS_BASE_REPOSITORY:=https://hg.mozilla.org/build/tools}

Ahh, nice! Inheriting these is much cleaner.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a66d2732dfc6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a66d2732dfc6

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1164623: align env variable names with B2G; r=mrrrgn