Closed Bug 1164715 Opened 5 years ago Closed 4 years ago

Polish default thumbnails in tabs tray

Categories

(Firefox for Android :: Theme and Visual Design, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: antlam, Assigned: mcomella)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

Filing this to double check we have our "empty states" in order.

Normal tabs
---
Color: Panel header matte
Icon: globe (default grey)

Private tabs
---
Color: TBD
Icon: TBD (likely mask instead of globe) but will consider bug 1139202 and bug 1018456 as well.
What's a zombie tab?
Flags: needinfo?(alam)
Attached image prev_mob_tray.png
Sorry, somehow I thought it was a term :P

It's the about:home preview, when we use it for tabs that we can't provide screenshots for anymore.
Flags: needinfo?(alam)
Summary: Polish UI for zombie tabs → Polish default thumbnails on about:home
Summary: Polish default thumbnails on about:home → Polish site default thumbnails on about:home
I don't think this bug is an issue anymore with our new tabs tray?

But before I close it, I just want to double check the colors are:

Normal tabs
---
Background Color: about page header grey #f5f5f5
Icon: tabs tray icon grey #AFB1B3

If not, we could make this mentor-able or just update it if it's easy enough :)
Flags: needinfo?(michael.l.comella)
Anthony, while investigating, I found out the top sites default thumbnail background color is "#ECF0F3" – should that also be updated to about_page_header_grey?
Flags: needinfo?(michael.l.comella) → needinfo?(alam)
Assignee: nobody → michael.l.comella
Comment on attachment 8735017 [details]
MozReview Request: Bug 1164715 - Update tabs tray default thumbnail background color. r=grisha

https://reviewboard.mozilla.org/r/42521/#review39291

Looks good!
Attachment #8735017 - Flags: review?(gkruglov) → review+
https://hg.mozilla.org/mozilla-central/rev/34a3c2d3359f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Flags: needinfo?(alam)
(In reply to Michael Comella (:mcomella) from comment #5)
> Anthony, while investigating, I found out the top sites default thumbnail
> background color is "#ECF0F3" – should that also be updated to
> about_page_header_grey?

This is bug 1242629.
Summary: Polish site default thumbnails on about:home → Polish default thumbnails in tabs tray
You need to log in before you can comment on or make changes to this bug.