1164715 - Polish default thumbnails in tabs tray

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Filing this to double check we have our "empty states" in order.

Normal tabs
---
Color: Panel header matte
Icon: globe (default grey)

Private tabs
---
Color: TBD
Icon: TBD (likely mask instead of globe) but will consider bug 1139202 and bug 1018456 as well.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

What's a zombie tab?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_mob_tray.png

Sorry, somehow I thought it was a term :P

It's the about:home preview, when we use it for tabs that we can't provide screenshots for anymore.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: trayglobe.zip

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I don't think this bug is an issue anymore with our new tabs tray?

But before I close it, I just want to double check the colors are:

Normal tabs
---
Background Color: about page header grey #f5f5f5
Icon: tabs tray icon grey #AFB1B3

If not, we could make this mentor-able or just update it if it's easy enough :)

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Anthony, while investigating, I found out the top sites default thumbnail background color is "#ECF0F3" – should that also be updated to about_page_header_grey?

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1164715 - Update tabs tray default thumbnail background color. r=grisha

The icon foreground was already the color antlam wanted it to be.

Review commit: https://reviewboard.mozilla.org/r/42521/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42521/

Comment 7

[:Grisha Kruglov]

Comment on attachment 8735017 [details]
MozReview Request: Bug 1164715 - Update tabs tray default thumbnail background color. r=grisha

https://reviewboard.mozilla.org/r/42521/#review39291

Looks good!

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/34a3c2d3359fb3b233a2a46f4e176459ace6b354
Bug 1164715 - Update tabs tray default thumbnail background color. r=grisha

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34a3c2d3359f

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #5)
> Anthony, while investigating, I found out the top sites default thumbnail
> background color is "#ECF0F3" – should that also be updated to
> about_page_header_grey?

This is bug 1242629.