Closed
Bug 1164715
Opened 9 years ago
Closed 8 years ago
Polish default thumbnails in tabs tray
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: antlam, Assigned: mcomella)
References
Details
Attachments
(3 files)
Filing this to double check we have our "empty states" in order. Normal tabs --- Color: Panel header matte Icon: globe (default grey) Private tabs --- Color: TBD Icon: TBD (likely mask instead of globe) but will consider bug 1139202 and bug 1018456 as well.
Reporter | ||
Comment 2•9 years ago
|
||
Sorry, somehow I thought it was a term :P It's the about:home preview, when we use it for tabs that we can't provide screenshots for anymore.
Flags: needinfo?(alam)
Assignee | ||
Updated•9 years ago
|
Summary: Polish UI for zombie tabs → Polish default thumbnails on about:home
Assignee | ||
Updated•9 years ago
|
Summary: Polish default thumbnails on about:home → Polish site default thumbnails on about:home
Reporter | ||
Comment 3•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 4•8 years ago
|
||
I don't think this bug is an issue anymore with our new tabs tray? But before I close it, I just want to double check the colors are: Normal tabs --- Background Color: about page header grey #f5f5f5 Icon: tabs tray icon grey #AFB1B3 If not, we could make this mentor-able or just update it if it's easy enough :)
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 5•8 years ago
|
||
Anthony, while investigating, I found out the top sites default thumbnail background color is "#ECF0F3" – should that also be updated to about_page_header_grey?
Flags: needinfo?(michael.l.comella) → needinfo?(alam)
Assignee | ||
Comment 6•8 years ago
|
||
The icon foreground was already the color antlam wanted it to be. Review commit: https://reviewboard.mozilla.org/r/42521/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42521/
Attachment #8735017 -
Flags: review?(gkruglov)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → michael.l.comella
Comment 7•8 years ago
|
||
Comment on attachment 8735017 [details] MozReview Request: Bug 1164715 - Update tabs tray default thumbnail background color. r=grisha https://reviewboard.mozilla.org/r/42521/#review39291 Looks good!
Attachment #8735017 -
Flags: review?(gkruglov) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/34a3c2d3359fb3b233a2a46f4e176459ace6b354 Bug 1164715 - Update tabs tray default thumbnail background color. r=grisha
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/34a3c2d3359f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(alam)
Assignee | ||
Comment 10•8 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #5) > Anthony, while investigating, I found out the top sites default thumbnail > background color is "#ECF0F3" – should that also be updated to > about_page_header_grey? This is bug 1242629.
Assignee | ||
Updated•8 years ago
|
Summary: Polish site default thumbnails on about:home → Polish default thumbnails in tabs tray
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•