Inherit from Tablet UI on Mobile UI (aka compact tabs)

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: antlam, Assigned: mhaigh)

Tracking

unspecified
Firefox 43
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(3 attachments)

Something we talked about before. The similarities here are becoming more and more apparent as phone screens get bigger and bigger. 

A good simple start would be to use the same UI we do in tablets, on the phone. Things like Page title on top, close tab "x" on top, tab preview dimensions, etc. are what I'm referring to.
Duplicate of this bug: 1170163
Note from the other bug:

"I'm on board with this. The prototype was pretty good but we should try to preserve the swipe-to-close functionality so we aren't trading off that UX for this UX."
Summary: Inherit from Tablet UI when tabs tray is in landscape mode → Inherit from Tablet UI on Mobile UI (aka compact tabs)
Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r?mcomella

This patch removes the multiple tab item layouts, repoints the adapters and moved some items in to non tablet directories.  If built using the TabsListLayout view, the portrait mode looks pretty dodgy as it stretches the view horizontally to fill the available space, landscape looks better.  We'll land this one after we remove the list layout.

As a side note, I need to ask antlam to have a look at the tab_close drawables as there was only a hdpi non tablet version and the tablet assets didn't seem to include an xhdpi version.  The ones in use in this patch are the old tablet assets..
Attachment #8648839 - Flags: review?(michael.l.comella)
Assignee: nobody → mhaigh
(In reply to Martyn Haigh (:mhaigh) from comment #4)
> As a side note, I need to ask antlam to have a look at the tab_close
> drawables as there was only a hdpi non tablet version and the tablet assets
> didn't seem to include an xhdpi version.  The ones in use in this patch are
> the old tablet assets..

There are a lot of "x" drawables – it'd be good to take a baby step here to consolidate if possible.
Comment on attachment 8648839 [details]
MozReview Request: Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella

https://reviewboard.mozilla.org/r/16303/#review14609

Damn, rb makes viewing renames and deletions difficult!

Otherwise, looks sound. :)
Attachment #8648839 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8648839 [details]
MozReview Request: Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella

Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella
Attachment #8648839 - Attachment description: MozReview Request: Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r?mcomella → MozReview Request: Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella
Bug 1193745 - Implement the tablet tabs tray grid view on mobile r?mcomella
Attachment #8652915 - Flags: review?(michael.l.comella)
Ah - pushed review to the wrong bug!
Attachment #8652915 - Flags: review?(michael.l.comella)
url:        https://hg.mozilla.org/integration/fx-team/rev/b94599998a85d13ba208d54adc9e7d8c825de0f5
changeset:  b94599998a85d13ba208d54adc9e7d8c825de0f5
user:       Martyn Haigh <mhaigh@mozilla.org>
date:       Tue Aug 25 12:43:43 2015 +0100
description:
Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella
https://hg.mozilla.org/mozilla-central/rev/b94599998a85
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Blocks: 1203036
You need to log in before you can comment on or make changes to this bug.