1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_mob_tray_landscape.png

Something we talked about before. The similarities here are becoming more and more apparent as phone screens get bigger and bigger. 

A good simple start would be to use the same UI we do in tablets, on the phone. Things like Page title on top, close tab "x" on top, tab preview dimensions, etc. are what I'm referring to.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Note from the other bug:

"I'm on board with this. The prototype was pretty good but we should try to preserve the swipe-to-close functionality so we aren't trading off that UX for this UX."

Comment 3

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ea79e6f05b5

Comment 4

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella

Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r?mcomella

This patch removes the multiple tab item layouts, repoints the adapters and moved some items in to non tablet directories.  If built using the TabsListLayout view, the portrait mode looks pretty dodgy as it stretches the view horizontally to fill the available space, landscape looks better.  We'll land this one after we remove the list layout.

As a side note, I need to ask antlam to have a look at the tab_close drawables as there was only a hdpi non tablet version and the tablet assets didn't seem to include an xhdpi version.  The ones in use in this patch are the old tablet assets..

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Martyn Haigh (:mhaigh) from comment #4)
> As a side note, I need to ask antlam to have a look at the tab_close
> drawables as there was only a hdpi non tablet version and the tablet assets
> didn't seem to include an xhdpi version.  The ones in use in this patch are
> the old tablet assets..

There are a lot of "x" drawables – it'd be good to take a baby step here to consolidate if possible.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8648839 [details]
MozReview Request: Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella

https://reviewboard.mozilla.org/r/16303/#review14609

Damn, rb makes viewing renames and deletions difficult!

Otherwise, looks sound. :)

Comment 7

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f12fdf0a589

Comment 8

[Martyn Haigh (:mhaigh)]

Comment on attachment 8648839 [details]
MozReview Request: Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella

Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella

Comment 9

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1193745 - Implement the tablet tabs tray grid view on mobile r?mcomella

Bug 1193745 - Implement the tablet tabs tray grid view on mobile r?mcomella

Comment 10

[Martyn Haigh (:mhaigh)]

Ah - pushed review to the wrong bug!

Comment 11

[Martyn Haigh (:mhaigh)]

url:        https://hg.mozilla.org/integration/fx-team/rev/b94599998a85d13ba208d54adc9e7d8c825de0f5
changeset:  b94599998a85d13ba208d54adc9e7d8c825de0f5
user:       Martyn Haigh <[e-mail]>
date:       Tue Aug 25 12:43:43 2015 +0100
description:
Bug 1164723 - Inherit from Tablet UI on Mobile UI (aka compact tabs); r=mcomella

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b94599998a85