1203036 - Put tab tray improvements behind nightly flag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

To avoid letting the tabs tray for mobile ride the trains, lets pref it off.

Comment 1

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=89595d9dbf07

Comment 2

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1203036 - Put tab tray improvements behind nightly flag; r?mcomella

Bug 1203036 - Put tab tray improvements behind nightly flag; r?mcomella

This patch reintroduced changes behind a nightly flag removed by:

    1161638: Remove the chrome at the bottom of the screen in the Tabs Tray
    1164723: Inherit from Tablet UI on Mobile UI (aka compact tabs)
    1193745: Implement the tablet tabs tray grid view on mobile

I've also done a bit of work to allow the chrome to sit at the correct Y location in landscape on mobile devices when the tabs panel is shown to account for bug 1193374 which adjusts the aspect ratio of the tabs panel thumnbnails and didn't need to be hidden behind a nightly flag. Tablets remain unaffected by this change.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8659220 [details]
MozReview Request: Bug 1203036 - Put tab tray improvements behind nightly flag; r?mcomella

https://reviewboard.mozilla.org/r/18773/#review16809

Looks good. I skimmed over the stuff I thought was previously removed and reintroduced for this patch, and checked that the new Nightly flags look good.

Comment 4

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/b9fb82ab0a0d0b16fb526b85d0298861aab4d35c
Bug 1203036 - Put tab tray improvements behind nightly flag; r=mcomella

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b9fb82ab0a0d