Closed Bug 1164731 Opened 7 years ago Closed 6 years ago

Waterfall does not update selection when rerendered via flame chart scroll

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Version:
41 Branch
Type:
defect

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(2 files)

waterfall_no_update.gif
1.60 MB, image/gif
Details
1164731-flamegraph-select.patch
7.96 KB, patch
vporof
: review+
Details | Diff | Splinter Review
Attached image waterfall_no_update.gif — 
Changing selection via flamechart scrolling does not update the waterfall.

View attachment; scrolling in the flamechart and going back to the waterfall, the waterfall view never changes.
Blocks: perf-waterfall
Priority: -- → P2
This is surely a regression.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Comment on attachment 8616084 [details] [diff] [review]
1164731-flamegraph-select.patch

Review of attachment 8616084 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we don't need the stopPropagation thing anymore? Could remove it now, or later.
Attachment #8616084 - Flags: review?(vporof) → review+
Probably makes sense to revisit all those properties once we atleast make it possible for the views to be extensible -- like write the details views as if they're addons (without hooks to PerformanceController/ObverviewView, etc)
https://hg.mozilla.org/mozilla-central/rev/3f9c72217e7f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.