1164731 - Waterfall does not update selection when rerendered via flame chart scroll

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: waterfall_no_update.gif

Changing selection via flamechart scrolling does not update the waterfall.

View attachment; scrolling in the flamechart and going back to the waterfall, the waterfall view never changes.

Comment 1

[Victor Porof [:vporof][:vp]]

This is surely a regression.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1164731-flamegraph-select.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8875a30e75f0

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8616084 [details] [diff] [review]
1164731-flamegraph-select.patch

Review of attachment 8616084 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we don't need the stopPropagation thing anymore? Could remove it now, or later.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Probably makes sense to revisit all those properties once we atleast make it possible for the views to be extensible -- like write the details views as if they're addons (without hooks to PerformanceController/ObverviewView, etc)

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

https://hg.mozilla.org/integration/fx-team/rev/3f9c72217e7f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3f9c72217e7f