Closed
Bug 1164731
Opened 10 years ago
Closed 10 years ago
Waterfall does not update selection when rerendered via flame chart scroll
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(2 files)
1.60 MB,
image/gif
|
Details | |
7.96 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Changing selection via flamechart scrolling does not update the waterfall.
View attachment; scrolling in the flamechart and going back to the waterfall, the waterfall view never changes.
Assignee | ||
Updated•10 years ago
|
Blocks: perf-waterfall
Priority: -- → P2
Comment 1•10 years ago
|
||
This is surely a regression.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8616084 -
Flags: review?(vporof)
Comment 3•10 years ago
|
||
Comment on attachment 8616084 [details] [diff] [review]
1164731-flamegraph-select.patch
Review of attachment 8616084 [details] [diff] [review]:
-----------------------------------------------------------------
I guess we don't need the stopPropagation thing anymore? Could remove it now, or later.
Attachment #8616084 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Probably makes sense to revisit all those properties once we atleast make it possible for the views to be extensible -- like write the details views as if they're addons (without hooks to PerformanceController/ObverviewView, etc)
Assignee | ||
Comment 5•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•