1164733 - [Settings][Keyboard]The name of the Arabic keyboard is cut off on the bottom

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P2)

Description

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: Arabic keyboard.png

Description:
When viewing the Build-in Keyboards screen, the Arabic keyboard has its name cut off on the bottom.  This issue occurs in both LTR and RTL configurations because the keyboard's name is always in Arabic.

Repro Steps:
1) Update a Flame to 20150513010202
2) Open Settings > Keyboards > Build in Keyboards
3) Note the Arabic Keyboard under Installed Keyboards

Actual:
The bottom portion of the text is cut off.

Expected:
The text is fully viewed.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150513010202
Gaia: 0d6c04f13fd385bda045f4e539b2a67cb5d84b1d
Gecko: 62d9b117c688
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0


Repro frequency: 5/5
See attached: screenshot

Comment 1

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue cannot happen on 2.2 because the installed keyboards section does not exist.  Thus it is not a regression.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150513002507
Gaia: e048df68f6f4853b5826a8816e143d95258149de
Gecko: 0e6b4aab2b94
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Delphine, can you take a look at this please?

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:

Nominating this for 3.0 to avoid confusion since letters are cut off

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Adding to 2.5 RTL Keyboard meta

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Ahmed: how bad is this? I think we should get a fix for this, please confirm

Comment 6

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Delphine Lebédel [:delphine - use need info] from comment #5)
> Ahmed: how bad is this? I think we should get a fix for this, please confirm

On a level of 1 to 5 where 5 is worst, this is 1.
However it should be fixed and it should not be left hanging.

My proposal for a solution would be using :lang(ar) { /* reduced font size for arabic */ } for the layout name element.

On the other hand. Working on bug 1182037 made me realize that the huge Arabic font size is a global issue. I did some calculations and according to my findings: in *most* (not all) of the places where Arabic is used, font size needs to be reduced around 30%, give or take 2%. So I wonder if there would be a more generic solution for that, that could maybe gets initialized in the system wrapper or something.

Delphine, do you know someone who can I ask about that?

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #6)
> On the other hand. Working on bug 1182037 made me realize that the huge
> Arabic font size is a global issue. I did some calculations and according to
> my findings: in *most* (not all) of the places where Arabic is used, font
> size needs to be reduced around 30%, give or take 2%. So I wonder if there
> would be a more generic solution for that, that could maybe gets initialized
> in the system wrapper or something.
> 
> Delphine, do you know someone who can I ask about that?
Thanks for this feedback Ahmed. 
Flagging UX to see if they can help! thanks

Comment 8

[Tiffanie Shakespeare [:tif]]

Passing NI to Patryk - looks like the string either needs to be moved higher or made smaller.

Thanks for pinging the UX team!

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks Tiffanie! 
Patryk: please also refer to comment 6 where Ahmed seems to suggest we might need a smaller font across UI. thanks!

Comment 10

[Patryk Adamczyk [:patryk] UX]

Makes sense, I am not an arabic speaker, so I will defer to Ahmed to decide on what size is legible for arabic.

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

Ah putting the ni back on Ahmed again then :) 
:nefzaoui: I guess you can just advise here what you think would be better and work this out with Patryk.

Comment 12

[Ahmed Nefzaoui [:Nefzaoui]]

I'd recommend making the font ~30% smaller (as I said in most of the cases, not all). Although I'm not sure how technically this be done in a global way all across gaia. I can't imagine that there's a way to do that and we probably would have to handle each case separately.
Can you please ping someone from dev team to have their insight on this?
Thanks!

Comment 13

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #12)
> I'd recommend making the font ~30% smaller (as I said in most of the cases,
> not all). Although I'm not sure how technically this be done in a global way
> all across gaia. I can't imagine that there's a way to do that and we
> probably would have to handle each case separately.
> Can you please ping someone from dev team to have their insight on this?
> Thanks!

Referring to Droid Naskh UI Arabic.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I can fix this, but bug 1193136 so far prevented me from access this part of UI.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Flame-keyboard-settings.png

Not reproduced on the latest build ... Please mark WFM if verified.

Comment 16

[Pi Wei Cheng [:piwei] (inactive)]

Confirmed that this is no longer occurring on latest Aries and Flame. Comment 15 screenshot is observed on both devices.

Device: Flame 2.5
BuildID: 20150821030209
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: 095988abdc560bf8ba07a94a425c6922a3e9bfd6
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Aries 2.5
BuildID: 20150820203627
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: 7a6cd1616542b9fb22274fb315502fce9bad2a6c
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0