1164858 - EME is not enabled by default when switching between builds

Status: RESOLVED INVALID

(Firefox :: General, defect, P2)

Description

[Ada [:adalucinet]]

Logged based on bug 1144903 comment 35, just to have it tracked.

Reproducible with EME - free repack build via http://stage.mozilla.org/pub/mozilla.org/firefox/candidates/38.0-candidates/build2/partner-repacks/EME-free/
Affected platforms: Windows 7 32 bit and Windows Vista 32 bit

1. Install latest 40.0a1 & wait for the plugin to download.
2. Disable EME plugin.
3. Install EME free build in the same folder (as in step 1)
4. Re-install latest 40.0a1

Expected result:
EME is enabled.

Actual results: 
EME is not enabled by default: 
* Play DRM not enabled and the plugin is not downloaded; 
* 'media.eme.enabled' not present in prefs.js; 
* 'media.eme.enabled' is false in about:config

Comment 1

[:Gijs (he/him)]

(In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #0)
> Logged based on bug 1144903 comment 35, just to have it tracked.
> 
> Reproducible with EME - free repack build via
> http://stage.mozilla.org/pub/mozilla.org/firefox/candidates/38.0-candidates/
> build2/partner-repacks/EME-free/
> Affected platforms: Windows 7 32 bit and Windows Vista 32 bit
> 
> 1. Install latest 40.0a1 & wait for the plugin to download.
> 2. Disable EME plugin.
> 3. Install EME free build in the same folder (as in step 1)
> 4. Re-install latest 40.0a1
> 
> Expected result:
> EME is enabled.
> 
> Actual results: 
> EME is not enabled by default: 
> * Play DRM not enabled and the plugin is not downloaded; 
> * 'media.eme.enabled' not present in prefs.js; 
> * 'media.eme.enabled' is false in about:config

Without trying this, if I read the steps correctly, this is not actually what comment 35 or comment 8 in bug 1144903 were about. It happens only because you're installing in the same directory without erasing the EME-free build. So now the distribution dir will still be there and it will still be overriding preferences.

Arguably the installer should erase the distribution directory, if any. That's an installer issue, I think.

Robert, is that right? Can we add this functionality to the installer?

(CC'ing mconnor because distribution and stuff)

Comment 2

[Robert Strong (they/them - no direct email)]

(In reply to :Gijs Kruitbosch from comment #1)
> (In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #0)
> > Logged based on bug 1144903 comment 35, just to have it tracked.
> > 
> > Reproducible with EME - free repack build via
> > http://stage.mozilla.org/pub/mozilla.org/firefox/candidates/38.0-candidates/
> > build2/partner-repacks/EME-free/
> > Affected platforms: Windows 7 32 bit and Windows Vista 32 bit
> > 
> > 1. Install latest 40.0a1 & wait for the plugin to download.
> > 2. Disable EME plugin.
> > 3. Install EME free build in the same folder (as in step 1)
> > 4. Re-install latest 40.0a1
> > 
> > Expected result:
> > EME is enabled.
> > 
> > Actual results: 
> > EME is not enabled by default: 
> > * Play DRM not enabled and the plugin is not downloaded; 
> > * 'media.eme.enabled' not present in prefs.js; 
> > * 'media.eme.enabled' is false in about:config
> 
> Without trying this, if I read the steps correctly, this is not actually
> what comment 35 or comment 8 in bug 1144903 were about. It happens only
> because you're installing in the same directory without erasing the EME-free
> build. So now the distribution dir will still be there and it will still be
> overriding preferences.
> 
> Arguably the installer should erase the distribution directory, if any.
> That's an installer issue, I think.
> 
> Robert, is that right? Can we add this functionality to the installer?
The installer does remove the distribution dir

Installer removes it if it exists unless installing administratively using an ini file that specifies RemoveDistributionDir=false
http://mxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/installer.nsi#234

uninstaller removes it if it exists
http://mxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/uninstaller.nsi#387

Comment 3

[Robert Strong (they/them - no direct email)]

Just tried it out and it didn't remove the distribution dir. :(

I'll try to figure out why

Comment 4

[Robert Strong (they/them - no direct email)]

Filed bug 1165135

Comment 5

[Ada [:adalucinet]]

With the fix from bug 1165135, the expected result is partially encountered:
* 'Play DRM content' checkbox is marked in Options/Content tab
* 'media.eme.enabled' is true in about:config
* the plugin is *NOT* downloaded; it gets stuck in '..will be install shortly' state. If I select to Find updates or reset 'media.gmp-manager.lastCheck', the plugin is successfully downloaded.

Tested with 38.0.5 beta 3 EME free (Build ID: 20150518141916) and latest 40.0a1 (from 2015-05-18) builds, under Windows 7 64-bit.

Comment 6

[Ada [:adalucinet]]

Chris, could you please shed some light on:

> * the plugin is *NOT* downloaded; it gets stuck in '..will be install
> shortly' state. If I select to Find updates or reset
> 'media.gmp-manager.lastCheck', the plugin is successfully downloaded.

Thanks in advance!

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #6)
> Chris, could you please shed some light on:
> 
> > * the plugin is *NOT* downloaded; it gets stuck in '..will be install
> > shortly' state. If I select to Find updates or reset
> > 'media.gmp-manager.lastCheck', the plugin is successfully downloaded.

I tested this, and I see that the plugin is disabled in the add-on manager UI. Your STR disabled the Adobe GMP. It seems to me that us remembering that the GMP was disabled is reasonable to before the install of the EME free repack after the EME free repack has been uninstalled, since whether the plugin is disabled is stored in the users profile which is separate from the Firefox install package itself.

I think we could close this bug?

Comment 8

[Ada [:adalucinet]]

(In reply to Chris Pearce (:cpearce) from comment #7)
> (In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #6)
> > Chris, could you please shed some light on:
> > 
> > > * the plugin is *NOT* downloaded; it gets stuck in '..will be install
> > > shortly' state. If I select to Find updates or reset
> > > 'media.gmp-manager.lastCheck', the plugin is successfully downloaded.
> 
> I tested this, and I see that the plugin is disabled in the add-on manager
> UI. Your STR disabled the Adobe GMP. It seems to me that us remembering that
> the GMP was disabled is reasonable to before the install of the EME free
> repack after the EME free repack has been uninstalled, since whether the
> plugin is disabled is stored in the users profile which is separate from the
> Firefox install package itself.
> 
> I think we could close this bug?

Yes, indeed - the behavior is expected; Marking accordingly.