1165135 - distribution directory not removed on pave over install

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Comment 1

[Robert Strong (they/them - no direct email)]

Note: the code that caused this was added for the update hotfix so we can support installing without removing the distribution dir for repacks such as the eu-ballot

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

Meh!

Comment 3

[Robert Strong (they/them - no direct email)]

[Tracking Requested - why for this release]:
This causes bugs such as bug 1164858

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b2f7c610539c

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 8606048 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1164858 - added to support installing without removing the distribution dir for repacks such as the eu-ballot
[User impact if declined]: Users installing a non repack build over a repack build won't have the repack customizations removed.
[Describe test coverage new/current, TreeHerder]: Thoroughly tested locally.
[Risks and why]: Little to none. The patch is a simple one line fix that just initializes an nsis variable
[String/UUID change made/needed]: None

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8606048 [details] [diff] [review]
patch

Should also get this in esr38

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2f7c610539c

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8606048 [details] [diff] [review]
patch

Should be in the first beta of 39 and ESR 38.1.0.

Comment 9

[:Gijs (he/him)]

Comment on attachment 8606048 [details] [diff] [review]
patch

Approval Request Comment: comment #5

Tracking for 38.0.5 was requested so I suspect this needs uplifting to release for the 38.0.5 release. Sylvestre, can you clarify?

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8606048 [details] [diff] [review]
patch

Well, Robert didn't ask for it but I am happy to take it too.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8518dcc3b49b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d314b3559a93

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/4bfd19d00ed4

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/1f06098329ba

Comment 15

[Ada [:adalucinet]]

Verified fixed with 38.0.5 beta 3 EME free build (Build ID: 20150518141916), under Windows 7 64-bit - distribution folder is correctly removed.

Comment 16

[Ada [:adalucinet]]

Verified fixed with 39.0b4 EME free build 2 (Build ID: 20150609130336), under Windows 7 64-bit and Windows 8.1 32-bit.

Comment 17

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Removing qe-verify+ since this was already verified on Firefox 38.0.5 and 39.

Comment 18

[Petruta Horea [:phorea], Desktop Test Engineering]

Reproduced with Firefox 38 RC build 3 under Win 7 64-bit.
There are no repack builds for ESR, so I installed 38.1esr build over a regular 38 repack build and the distribution folder was correctly removed. Marking as verified.