1165015 - Opening the Pocket subview in m-bc leads to leaked windows and a docshell

Status: NEW

(Firefox :: Pocket, defect, P3)

Description

[Matthew N. [:MattN]]

Attachment: browser_UITour_pocket.js log in a debug build

While working on browser_UITour_pocket.js (the first test to open the Pocket panel AFAIK), I ran into some reported leaks:
leaked 2 window(s) until shutdown [url = chrome://browser/content/pocket/panels/signup.html?pockethost=getpocket.com&fxasignedin=0&variant=storyboard&inoverflowmenu=false&locale=en-US&panelId=2]
windows(s) leaked: [pid = 29932] [serial = 35], [pid = 29932] [serial = 45]
leaked 1 docShell(s) until shutdown
docShell(s) leaked: [pid = 29932] [id = 15]

Since I don't think the leaks are caused by UITour's usage of the panel and since we needed that patch uplifted to 38.0.5, and because I'm told the Pocket code may significantly change in the future, I disabled the tests in debug builds (where leak checking runs).

Comment 1

[Justin Dolske [:Dolske]]

P3 since this is at worst a small 1-time cost (and not, say, a leak every time the panel is opened).

Also I suspect bug 1164940 might actually fix this?