Closed
Bug 1165019
Opened 9 years ago
Closed 9 years ago
Un-hide Android 4.3 Debug mochitests on try and run on trunk trees
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gbrown, Assigned: kmoir)
References
Details
Attachments
(3 files, 2 obsolete files)
16.55 KB,
patch
|
Details | Diff | Splinter Review | |
6.12 KB,
patch
|
jlund
:
review+
|
Details | Diff | Splinter Review |
5.17 KB,
patch
|
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
Android 4.3 Debug plain mochitests (M1 ... M16) and mochitest-gl (mochitest-gl1 .. mochitest-gl4) are green. These jobs can be un-hidden on try and run on all trunk trees. Corresponding Android 4.0 Debug jobs can be retired. https://treeherder.mozilla.org/#/jobs?repo=try&revision=36a24f9e0398&exclusion_profile=false
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kmoir
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
builder diff
Assignee | ||
Updated•9 years ago
|
Attachment #8607714 -
Flags: review?(jlund)
Reporter | ||
Comment 3•9 years ago
|
||
Thanks Kim. I'm afraid I need to hit "pause" on the check-in here: A newly added test has turned mochitest-gl4 perma-orange.
Reporter | ||
Comment 4•9 years ago
|
||
(In reply to Kim Moir [:kmoir] from comment #2) > Created attachment 8607729 [details] > bug1165019builder.diff < Android 4.3 armv7 API 11+ try debug test plain-reftest-1 ScriptFactory < Android 4.3 armv7 API 11+ try debug test plain-reftest-2 ScriptFactory ... Are the changes to reftests on try intentional?
Assignee | ||
Updated•9 years ago
|
Attachment #8607714 -
Flags: review?(jlund)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8607729 -
Attachment is obsolete: true
Assignee | ||
Comment 6•9 years ago
|
||
fixed patch
Attachment #8607714 -
Attachment is obsolete: true
Attachment #8608190 -
Flags: review?(jlund)
Reporter | ||
Comment 7•9 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #3) > I'm afraid I need to hit "pause" on the check-in here: A newly added test > has turned mochitest-gl4 perma-orange. That's resolved now - ready to go again. https://treeherder.mozilla.org/#/jobs?repo=try&revision=88b6fb871509&exclusion_profile=false
Comment 8•9 years ago
|
||
Comment on attachment 8608190 [details] [diff] [review] bug1165019.patch Review of attachment 8608190 [details] [diff] [review]: ----------------------------------------------------------------- tbh - I'm not entirely understanding all of this. There is a lot of re-assigning. However, I see the same dump_master/builderlist diff that you are so I think it's fine. :) ::: mozilla-tests/mobile_config.py @@ +2422,5 @@ > > # bug 1133833 enable Android 4.3 on trunk for opt only > # while disabling corresponding 4.0 tests > for name, branch in items_at_least(BRANCHES, 'gecko_version', 40): > + # Loop removes it from any branch that gets beyond here nit: whitespace @@ +2486,5 @@ > if branch['platforms'][platform]['enable_debug_unittests'] is True: > BRANCHES[name]['platforms'][platform][slave_plat]['debug_unittest_suites'] = deepcopy(ANDROID_MOZHARNESS_MOCHITEST + ANDROID_MOZHARNESS_JSREFTEST + ANDROID_MOZHARNESS_CRASHTEST + ANDROID_MOZHARNESS_PLAIN_REFTEST + ANDROID_MOZHARNESS_XPCSHELL) > > +for name, branch in items_at_least(BRANCHES, 'gecko_version', 41): > + # Loop removes it from any branch that gets beyond here 'removes it' feels a little vague. is this comment a copy from another loop? @@ +2502,5 @@ > + continue > + BRANCHES[name]['platforms']['android-api-11']['ubuntu64_vm_armv7_large'] = { > + 'opt_unittest_suites': deepcopy(ANDROID_4_3_C3_DICT['opt_unittest_suites']), > + 'debug_unittest_suites': deepcopy(ANDROID_4_3_C3_TRUNK_DICT['debug_unittest_suites']),} > + BRANCHES[name]['platforms']['android-api-11']['panda_android']['debug_unittest_suites'] = deepcopy(ANDROID_MOZHARNESS_JSREFTEST + ANDROID_MOZHARNESS_CRASHTEST + ANDROID_MOZHARNESS_PLAIN_REFTEST + ANDROID_MOZHARNESS_XPCSHELL) nit: whitespace
Attachment #8608190 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 9•9 years ago
|
||
patch to incorporate feedback from review Thanks for the feedback Jordan, your reviews are always very thorough and thoughtful:-)
Assignee | ||
Updated•9 years ago
|
Attachment #8609394 -
Flags: checked-in+
Assignee | ||
Comment 10•9 years ago
|
||
:sheriffs: Could you please unhide debug mochitests* on Android 4.3 on try? thanks
Flags: needinfo?(sheriffs)
Comment 11•9 years ago
|
||
Note that needinfo'ing a watcher account doesn't actually pester anybody to do anything :). I'll take it when I'm back tomorrow, though.
Flags: needinfo?(sheriffs) → needinfo?(ryanvm)
Assignee | ||
Comment 13•9 years ago
|
||
Thanks RyanVM!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•