1165019 - Un-hide Android 4.3 Debug mochitests on try and run on trunk trees

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Geoff Brown [:gbrown]]

Android 4.3 Debug plain mochitests (M1 ... M16) and mochitest-gl (mochitest-gl1 .. mochitest-gl4) are green. These jobs can be un-hidden on try and run on all trunk trees. Corresponding Android 4.0 Debug jobs can be retired.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=36a24f9e0398&exclusion_profile=false

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1165019.patch

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug1165019builder.diff

builder diff

Comment 3

[Geoff Brown [:gbrown]]

Thanks Kim.

I'm afraid I need to hit "pause" on the check-in here: A newly added test has turned mochitest-gl4 perma-orange.

Comment 4

[Geoff Brown [:gbrown]]

(In reply to Kim Moir [:kmoir] from comment #2)
> Created attachment 8607729 [details]
> bug1165019builder.diff

< Android 4.3 armv7 API 11+ try debug test plain-reftest-1 ScriptFactory
< Android 4.3 armv7 API 11+ try debug test plain-reftest-2 ScriptFactory
...

Are the changes to reftests on try intentional?

Comment 5

[Kim Moir [:kmoir] ET]

Attachment: bug1165019builder.diff

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1165019.patch

fixed patch

Comment 7

[Geoff Brown [:gbrown]]

(In reply to Geoff Brown [:gbrown] from comment #3)
> I'm afraid I need to hit "pause" on the check-in here: A newly added test
> has turned mochitest-gl4 perma-orange.

That's resolved now - ready to go again.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88b6fb871509&exclusion_profile=false

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8608190 [details] [diff] [review]
bug1165019.patch

Review of attachment 8608190 [details] [diff] [review]:
-----------------------------------------------------------------

tbh - I'm not entirely understanding all of this. There is a lot of re-assigning. However, I see the same dump_master/builderlist diff that you are so I think it's fine. :)

::: mozilla-tests/mobile_config.py
@@ +2422,5 @@
>  
>  # bug 1133833 enable Android 4.3 on trunk for opt only
>  # while disabling corresponding 4.0 tests
>  for name, branch in items_at_least(BRANCHES, 'gecko_version', 40):
> +    # Loop removes it from any branch that gets beyond here  

nit: whitespace

@@ +2486,5 @@
>              if branch['platforms'][platform]['enable_debug_unittests'] is True:
>                  BRANCHES[name]['platforms'][platform][slave_plat]['debug_unittest_suites'] = deepcopy(ANDROID_MOZHARNESS_MOCHITEST + ANDROID_MOZHARNESS_JSREFTEST + ANDROID_MOZHARNESS_CRASHTEST + ANDROID_MOZHARNESS_PLAIN_REFTEST + ANDROID_MOZHARNESS_XPCSHELL)
>  
> +for name, branch in items_at_least(BRANCHES, 'gecko_version', 41):
> +    # Loop removes it from any branch that gets beyond here

'removes it' feels a little vague. is this comment a copy from another loop?

@@ +2502,5 @@
> +                continue
> +            BRANCHES[name]['platforms']['android-api-11']['ubuntu64_vm_armv7_large'] = {
> +            'opt_unittest_suites': deepcopy(ANDROID_4_3_C3_DICT['opt_unittest_suites']),
> +            'debug_unittest_suites': deepcopy(ANDROID_4_3_C3_TRUNK_DICT['debug_unittest_suites']),}
> +            BRANCHES[name]['platforms']['android-api-11']['panda_android']['debug_unittest_suites'] = deepcopy(ANDROID_MOZHARNESS_JSREFTEST + ANDROID_MOZHARNESS_CRASHTEST + ANDROID_MOZHARNESS_PLAIN_REFTEST + ANDROID_MOZHARNESS_XPCSHELL) 

nit: whitespace

Comment 9

[Kim Moir [:kmoir] ET]

Attachment: bug1165019-2.patch

patch to incorporate feedback from review

Thanks for the feedback Jordan, your reviews are always very thorough and thoughtful:-)

Comment 10

[Kim Moir [:kmoir] ET]

:sheriffs: Could you please unhide debug mochitests* on Android 4.3 on try? thanks

Comment 11

[(PTO June 19-July 7) Ryan VanderMeulen]

Note that needinfo'ing a watcher account doesn't actually pester anybody to do anything :). I'll take it when I'm back tomorrow, though.

Comment 12

[(PTO June 19-July 7) Ryan VanderMeulen]

Done.

Comment 13

[Kim Moir [:kmoir] ET]

Thanks RyanVM!