1165103 - Use a separate AppDelegate for MOZ_CHANNEL_AURORA

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Brian Nicholson (:bnicholson)]

Just like we're using a separate TestAppDelegate in bug 1162999, we could create an AuroraAppDelegate to clean up all of the hard-to-read #ifdefs.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/468

Built on top of bug 1162999, so you can ignore the first two commits.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8606058 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/468

Looks good. Just know that even though AuroraAppDelegate is a subclass and not used in a normal build. it is still compiled and included and its static initializers are still being called. I don't see anything in there that could cause troubles, but keep it in mind that this happens.