Closed
Bug 1165103
Opened 9 years ago
Closed 9 years ago
Use a separate AppDelegate for MOZ_CHANNEL_AURORA
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
Just like we're using a separate TestAppDelegate in bug 1162999, we could create an AuroraAppDelegate to clean up all of the hard-to-read #ifdefs.
|
Assignee | |
Comment 1•9 years ago
|
||
Built on top of bug 1162999, so you can ignore the first two commits.
Attachment #8606058 -
Flags: review?(sarentz)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8606058 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/468
Looks good. Just know that even though AuroraAppDelegate is a subclass and not used in a normal build. it is still compiled and included and its static initializers are still being called. I don't see anything in there that could cause troubles, but keep it in mind that this happens.
Attachment #8606058 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•