1165136 - Remove `public` keywords from ChangeVerifier interface

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://mxr.mozilla.org/mozilla-central/search?string=interface%20changeverifier&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Intellij tells me it's redundant for interface methods!

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

The code you would be fixing are in our Robocop test framework, so you'll need to set that up too: https://wiki.mozilla.org/Auto-tools/Projects/Robocop

When you make changes in the mobile/android/tests/browser/robocop directory, you should only need to recompile Robocop, not the entire browser, for these changes.

While you're developing, I recommend running just a single test at a time because the full robocop test suite takes a long time to run (at least 30 minutes).

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 1

[Hieu Le]

Greetings,

I am new to Mozilla community. I'd like to take this one for my first bug. Can you assign it to me? Thank you :)

Comment 2

[Mike Hoye [:mhoye]]

Hieu - go for it! I've assigned it to you. Let us know if you have any questions by clicking the "Need More Information" box at the bottom of this bug, and picking a mentor.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Hieu - if you have a question, you should add your question to the comment box and then add the "Need more information from" flag.

Is there a specific question you have?

Comment 4

[Hieu Le]

Hi Michael,

Can you show me how to import Java project for the directory /mobile/android/tests/browser/robocop? I used to work with .sln or .vcxproj files (From Visual Studio for C/C++). I don't know if there is any backend build for Java to support this kind of thing here? Please advise

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Hieu Le from comment #4)
> Can you show me how to import Java project for the directory
> /mobile/android/tests/browser/robocop? I used to work with .sln or .vcxproj
> files (From Visual Studio for C/C++). I don't know if there is any backend
> build for Java to support this kind of thing here? Please advise

Unfortunately, the only IDEs we currently support are Intellij (preferred) and Eclipse. See [1] for setup instructions. You're welcome to try getting your IDE of choice to import our project, but we will be unable to help you if things go wrong. Note that our project layout is non-standard and has several pre-processed files so this could be difficult. If you attempt to use a different IDE and have questions about the build system specifically, nalexander is the person to ask.

On that note, you mentioned Visual Studio - are you running Windows? As far as I know, we don't support building directly on Windows. Instead, we recommend that Windows users build in a Linux VM. One dev, capella, has some experience with this.

[1]: https://wiki.mozilla.org/Mobile/Fennec/Android/IDEs

Comment 6

[Hieu Le]

Thank you for the respond.
I will try the link to setup for the work.

Comment 7

[Hieu Le]

the command ./mach ide intellij didn't work for me. It says:
"./mach: line 9 exec: python: not found"
Do you know if I missed something there?

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Hieu Le from comment #7)
> the command ./mach ide intellij didn't work for me. It says:
> "./mach: line 9 exec: python: not found"
> Do you know if I missed something there?

It seems like you do not have a Python interpreter installed. On Linux you can install Python using your favorite package manager. On MacOS X python should be pre-installed. If you are using Windows: You can download a Python interpreter from python.org but building Fennec is not yet supported on Windows according to the wiki[1] and bug 1169873. For general help building Fennec (and faster help, at least on working days depending on timezone) try joining the irc chat: #mobile on irc.mozilla.org (See [2]).

[1]: https://wiki.mozilla.org/Mobile/Fennec/Android#Building_Fennec
[2]: https://wiki.mozilla.org/IRC

Comment 9

[Giovanny Gongora [:gioyik]]

Attachment: 1165136.patch

Comment 10

[Giovanny Gongora [:gioyik]]

Hi,

I attached a patch for this bug. Could you review it and tell me if is ok?

Thanks

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hieu, I'm going to reassign this to Giovanny due to inactivity - let me know if you'd like another bug to work on.

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8637652 [details] [diff] [review]
1165136.patch

Review of attachment 8637652 [details] [diff] [review]:
-----------------------------------------------------------------

Same deal as bug 1183902 comment 6 - add the "checkin-needed" keyword when the push goes green.

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b492833da859

Comment 14

[Giovanny Gongora [:gioyik]]

Treeherder is green! Let's celebrate! :)

Comment 15

[Giovanny Gongora [:gioyik]]

Thank you Michael for the feedback. If there are more bugs to work on, I will be glad to work on them :)

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/11654ad37d5e

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11654ad37d5e

Comment 18

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Giovanny.

Perhaps you'd like to try bug 1128561 for back-end or bug 1091826 for front-end?