Use origin for BroadcastChannel

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
5 months ago

People

(Reporter: allstars.chh, Assigned: baku)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 affected, firefox42 fixed)

Details

Attachments

(1 attachment)

As in Bug 1163254 we will update the nsIPrincipal.origin, BroadcastChannel should use the new attributes. Check BroadcastChannel.GetOrigin.
In bug 1155153 I implemented the serialization of OriginAttributes for IPC. If we wait for that bug to land, I can take this bug.
No longer depends on: 1163254
Posted patch bc.patchSplinter Review
This patch, instead using nsContentUtils::GetUTFOrigin, uses principal::GetOrigin. It should be enough, correct?
Attachment #8629456 - Flags: review?(bobbyholley)
Comment on attachment 8629456 [details] [diff] [review]
bc.patch

Review of attachment 8629456 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks baku.
Attachment #8629456 - Flags: review?(bobbyholley) → review+
Assignee: nobody → amarchesini
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a70570dbb155
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.