Closed Bug 1188776 Opened 4 years ago Closed 4 years ago

Remove appId/isInBrowserElement from BroadcastChannel

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: allstars.chh, Assigned: baku)

References

Details

Attachments

(1 file)

Bug 1165270 already converted to use origin, so I think we could remove appId/isInBrowserElement from BroadcastChannelParent and BroadcastChannelService.
Assignee: nobody → amarchesini
Attached patch bc.patchSplinter Review
Attachment #8640479 - Flags: review?(bobbyholley)
Comment on attachment 8640479 [details] [diff] [review]
bc.patch

Review of attachment 8640479 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/glue/BackgroundParentImpl.cpp
@@ +350,1 @@
>                                              const PrincipalInfo& aPrincipalInfo,

Do we still need to be passing aPrincipalInfo here? Or is this an implementation of some more general interface?
Attachment #8640479 - Flags: review?(bobbyholley) → review+
we need it for RecvPBroadcastChannelConstructor where we check if the child can load this principal.
The prototype of that method is generated from the IPC constructor.
So yes, we need the principal.
Keywords: checkin-needed
can we get a try run ?
Flags: needinfo?(amarchesini)
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4ddd82cb5c0b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.