Closed Bug 1165287 Opened 9 years ago Closed 9 years ago

Glitches when opening hello panel

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal

Tracking

(firefox40 fixed, firefox41 fixed)

VERIFIED FIXED
mozilla41
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: bmaris, Assigned: standard8)

References

Details

(Whiteboard: [context])

Attachments

(2 files)

Attached image Gif showing the issue
Affected builds:
- Latest Nightly 41.0a1

Affected OS`s:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.9.5

STR:
1. Start Firefox
2. Click Hello icon
3. Click 'Get Started'
4. Click Hello icon
5. Repeat step 4

Expected results: No glitches or graphical issues are present.

Actual results: The new added 'Let's talk about this page' information glitches when Hello panel is opened.
Mike, what do you think about this? I tried it out a bit, and it seems that due to the hiding, you do get quite a bit of flickering when the panel opens. If we instead keep the old data, and just let it be updated a little later, that reduces the flickering effect.
Attachment #8609291 - Flags: review?(mdeboer)
Comment on attachment 8609291 [details] [diff] [review]
Don't remove the context data when hiding the Loop panel to try and avoid glitches/flickering in the display wen it opens.

Review of attachment 8609291 [details] [diff] [review]:
-----------------------------------------------------------------

I like it. Thanks!
Attachment #8609291 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/6a903d05a35c
Assignee: nobody → standard8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8609291 [details] [diff] [review]
Don't remove the context data when hiding the Loop panel to try and avoid glitches/flickering in the display wen it opens.

Approval Request Comment
[Feature/regressing bug #]: Context in conversations for Hello
[User impact if declined]: When opening the Hello panel it can appear to flicker badly.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, code covered by tests.
[Risks and why]: Low - small change to the flow to reduce the amount of flicker
[String/UUID change made/needed]: None
Attachment #8609291 - Flags: approval-mozilla-aurora?
Verified as fixed in latest Nightly across platforms (Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
Attachment #8609291 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1180655
You need to log in before you can comment on or make changes to this bug.