1165287 - Glitches when opening hello panel

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Gif showing the issue

Affected builds:
- Latest Nightly 41.0a1

Affected OS`s:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.9.5

STR:
1. Start Firefox
2. Click Hello icon
3. Click 'Get Started'
4. Click Hello icon
5. Repeat step 4

Expected results: No glitches or graphical issues are present.

Actual results: The new added 'Let's talk about this page' information glitches when Hello panel is opened.

Comment 1

[Mark Banner (:standard8)]

Attachment: Don't remove the context data when hiding the Loop panel to try and avoid glitches/flickering in the display wen it opens.

Mike, what do you think about this? I tried it out a bit, and it seems that due to the hiding, you do get quite a bit of flickering when the panel opens. If we instead keep the old data, and just let it be updated a little later, that reduces the flickering effect.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8609291 [details] [diff] [review]
Don't remove the context data when hiding the Loop panel to try and avoid glitches/flickering in the display wen it opens.

Review of attachment 8609291 [details] [diff] [review]:
-----------------------------------------------------------------

I like it. Thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6a903d05a35c

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6a903d05a35c

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8609291 [details] [diff] [review]
Don't remove the context data when hiding the Loop panel to try and avoid glitches/flickering in the display wen it opens.

Approval Request Comment
[Feature/regressing bug #]: Context in conversations for Hello
[User impact if declined]: When opening the Hello panel it can appear to flicker badly.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, code covered by tests.
[Risks and why]: Low - small change to the flow to reduce the amount of flicker
[String/UUID change made/needed]: None

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Verified as fixed in latest Nightly across platforms (Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ebfd11d92d95