Implement support for setting proxy in marionette via capabilities

RESOLVED FIXED in Firefox 42

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

({pi-marionette-client, pi-marionette-server})

unspecified
mozilla42
pi-marionette-client, pi-marionette-server
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

(Whiteboard: [marionette=1.0], URL)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Setting the proxy via capabilities is a requirement for webdriver. 

Spec bug is https://www.w3.org/Bugs/Public/show_bug.cgi?id=26391

Currently the capabilities spec prose[1] is being cleaned up that will allow the spec bug to be completed. 
[1] https://github.com/w3c/webdriver/pull/32
(Assignee)

Updated

4 years ago
Assignee: nobody → dburns
Keywords: ateam-marionette-client, ateam-marionette-server
Whiteboard: [marionette=1.0]
(Assignee)

Comment 1

3 years ago
Pull 32 has been merged and pull request for this is in https://github.com/w3c/webdriver/pull/72
(Assignee)

Comment 2

3 years ago
the PR 72 has been merged in and https://www.w3.org/Bugs/Public/show_bug.cgi?id=26391 is closed. Now to implement
(Assignee)

Updated

3 years ago
Depends on: 1174941
(Assignee)

Comment 4

3 years ago
Created attachment 8632763 [details]
MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy
Attachment #8632763 - Flags: review?(jgriffin)
https://reviewboard.mozilla.org/r/13119/#review11731

::: testing/marionette/driver.js:604
(Diff revision 1)
> +  let that = this;

'that' doens't seem to be used.

::: testing/marionette/driver.js:663
(Diff revision 1)
> +  logger.info('setup proxy has been entered')

I'm guessing this logger statement was left over from debugging, since it isn't very useful; should we delete it, or expand it and dump the proxy object?

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:28
(Diff revision 1)
> +                                    {

The indentation here is pretty weird.

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:12
(Diff revision 1)
> +        self.original = None

This line isn't needed.

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:54
(Diff revision 1)
> +

nit:  extra empty line here

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:228
(Diff revision 1)
> +

nit: two extra blank lines here
(Assignee)

Comment 6

3 years ago
Comment on attachment 8632763 [details]
MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy
(Assignee)

Comment 7

3 years ago
Comment on attachment 8632763 [details]
MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy
(Assignee)

Comment 8

3 years ago
all review comments have been addressed.
Attachment #8632763 - Flags: review?(jgriffin) → review+
Comment on attachment 8632763 [details]
MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

https://reviewboard.mozilla.org/r/13121/#review11835
(Assignee)

Comment 10

3 years ago
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/27039dda138e37c01747dfcc5d2c41f0ea346392
changeset:  27039dda138e37c01747dfcc5d2c41f0ea346392
user:       David Burns <dburns@mozilla.com>
date:       Tue Jul 14 00:51:58 2015 +0100
description:
Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r=jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy
https://hg.mozilla.org/mozilla-central/rev/27039dda138e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.