1165449 - Implement support for setting proxy in marionette via capabilities

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[David Burns :automatedtester]

Setting the proxy via capabilities is a requirement for webdriver. 

Spec bug is https://www.w3.org/Bugs/Public/show_bug.cgi?id=26391

Currently the capabilities spec prose[1] is being cleaned up that will allow the spec bug to be completed. 
[1] https://github.com/w3c/webdriver/pull/32

Comment 1

[David Burns :automatedtester]

Pull 32 has been merged and pull request for this is in https://github.com/w3c/webdriver/pull/72

Comment 2

[David Burns :automatedtester]

the PR 72 has been merged in and https://www.w3.org/Bugs/Public/show_bug.cgi?id=26391 is closed. Now to implement

Comment 3

[David Burns :automatedtester]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a0ef12f68ed

Comment 4

[David Burns :automatedtester]

Attachment: MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy

Comment 5

[Jonathan Griffin (:jgriffin)]

https://reviewboard.mozilla.org/r/13119/#review11731

::: testing/marionette/driver.js:604
(Diff revision 1)
> +  let that = this;

'that' doens't seem to be used.

::: testing/marionette/driver.js:663
(Diff revision 1)
> +  logger.info('setup proxy has been entered')

I'm guessing this logger statement was left over from debugging, since it isn't very useful; should we delete it, or expand it and dump the proxy object?

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:28
(Diff revision 1)
> +                                    {

The indentation here is pretty weird.

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:12
(Diff revision 1)
> +        self.original = None

This line isn't needed.

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:54
(Diff revision 1)
> +

nit:  extra empty line here

::: testing/marionette/client/marionette/tests/unit/test_proxy.py:228
(Diff revision 1)
> +

nit: two extra blank lines here

Comment 6

[David Burns :automatedtester]

Comment on attachment 8632763 [details]
MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy

Comment 7

[David Burns :automatedtester]

Comment on attachment 8632763 [details]
MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy

Comment 8

[David Burns :automatedtester]

all review comments have been addressed.

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8632763 [details]
MozReview Request: Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r?jgriffin

https://reviewboard.mozilla.org/r/13121/#review11835

Comment 10

[David Burns :automatedtester]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/27039dda138e37c01747dfcc5d2c41f0ea346392
changeset:  27039dda138e37c01747dfcc5d2c41f0ea346392
user:       David Burns <[e-mail]>
date:       Tue Jul 14 00:51:58 2015 +0100
description:
Bug 1165449: Add the ability to set a proxy via capabilities on Marionette session start; r=jgriffin

By passing an object to capabilities like

  {
    "requiredCapabilities": {
        "proxy": {... }
    }
  }

Specification detail at http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-the-proxy

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27039dda138e

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.