1165737 - Fix usage of NS_LITERAL_CSTRING in mailnews, port Bug 1155963 to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Stefan Sitter [:ssitter]]

Bug 1155963 changed how NS_LITERAL_CSTRING can be used. This currently results in Thunderbird build error like:

> mailnews/news/src/nsNntpService.cpp(732) : error C2146: syntax error : missing ')' before identifier 'kNewsRootURI'

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18527
repository: comm-central
start_time: 2015-05-17T12:10:27
who: ssitter[at]gmail[dot]com
machine: bld-linux64-spot-095
buildname: TB Linux comm-central leak test build
revision: 35679800b300

/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:94: error: expected primary-expression before '(' token
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:98: error: expected ')' before 'kNewsRootURI'
make[5]: *** [nsNntpService.o] Error 1
make[4]: *** [mailnews/news/src/target] Error 2make[5]: Leaving directory `/builds/slave/tb-c-cen-lx-d-0000000000000000/build/objdir-tb/mailnews/news/src'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18532
repository: comm-central
start_time: 2015-05-17T12:09:53
who: ssitter[at]gmail[dot]com
machine: bld-linux64-spot-197
buildname: TB Linux comm-central build
revision: 35679800b300

/builds/slave/tb-c-cen-lx-000000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:94: error: expected primary-expression before '(' token
/builds/slave/tb-c-cen-lx-000000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:98: error: expected ')' before 'kNewsRootURI'
make[5]: *** [nsNntpService.o] Error 1
make[4]: *** [mailnews/news/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18534
repository: comm-central
start_time: 2015-05-17T12:09:55
who: ssitter[at]gmail[dot]com
machine: bld-linux64-spot-141
buildname: TB Linux x86-64 comm-central leak test build
revision: 35679800b300

/builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:94: error: expected primary-expression before '(' token
/builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:98: error: expected ')' before 'kNewsRootURI'
make[5]: *** [nsNntpService.o] Error 1
make[4]: *** [mailnews/news/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18530
repository: comm-central
start_time: 2015-05-17T12:09:55
who: ssitter[at]gmail[dot]com
machine: bld-linux64-spot-255
buildname: TB Linux x86-64 comm-central build
revision: 35679800b300

/builds/slave/tb-c-cen-l64-00000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:94: error: expected primary-expression before '(' token
/builds/slave/tb-c-cen-l64-00000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:98: error: expected ')' before 'kNewsRootURI'
make[5]: *** [nsNntpService.o] Error 1
make[4]: *** [mailnews/news/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18531
repository: comm-central
start_time: 2015-05-17T12:09:50
who: ssitter[at]gmail[dot]com
machine: bld-lion-r5-072
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: 35679800b300

/builds/slave/tb-c-cen-m64-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:60: error: expected ')'
make[5]: *** [nsNntpService.o] Error 1
make[4]: *** [mailnews/news/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18533
repository: comm-central
start_time: 2015-05-17T12:09:50
who: ssitter[at]gmail[dot]com
machine: bld-lion-r5-088
buildname: TB OS X 10.7 comm-central build
revision: 35679800b300

/builds/slave/tb-c-cen-m64-00000000000000000/build/mailnews/news/src/nsNntpService.cpp:732:60: error: expected ')'
make[6]: *** [nsNntpService.o] Error 1
make[5]: *** [mailnews/news/src/target] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [build] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18535
repository: comm-central
start_time: 2015-05-17T12:09:50
who: ssitter[at]gmail[dot]com
machine: b-2008-ix-0166
buildname: TB WINNT 5.2 comm-central build
revision: 35679800b300

c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2146: syntax error : missing ')' before identifier 'kNewsRootURI'
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2146: syntax error : missing '(' before identifier 'kNewsRootURI'
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2661: 'StringBeginsWith' : no overloaded function takes 1 arguments
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2059: syntax error : ')'
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/news/src/nsNntpService.cpp(733) : error C2143: syntax error : missing ';' before '{'
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/news/src/nsNntpService.cpp(738) : error C2181: illegal else without matching if
mozmake.exe[5]: *** [nsNntpService.obj] Error 2
mozmake.exe[4]: *** [mailnews/news/src/target] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18528
repository: comm-central
start_time: 2015-05-17T12:09:50
who: ssitter[at]gmail[dot]com
machine: b-2008-ix-0074
buildname: TB WINNT 5.2 comm-central leak test build
revision: 35679800b300

c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2146: syntax error : missing ')' before identifier 'kNewsRootURI'
c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2146: syntax error : missing '(' before identifier 'kNewsRootURI'
c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2661: 'StringBeginsWith' : no overloaded function takes 1 arguments
c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp(732) : error C2059: syntax error : ')'
c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp(733) : error C2143: syntax error : missing ';' before '{'
c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mailnews/news/src/nsNntpService.cpp(738) : error C2181: illegal else without matching if
mozmake.exe[5]: *** [nsNntpService.obj] Error 2
mozmake.exe[4]: *** [mailnews/news/src/target] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Got a possible patch for this, stay tuned.

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Comment 11

[Kent James (:rkent)]

Comment on attachment 8606772 [details] [diff] [review]
Fix - v1

Review of attachment 8606772 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central changeset d6d954f11113

Comment 13

[[e-mail]]

Whoops. Sorry for not checking comm-central.