Closed Bug 1165737 Opened 5 years ago Closed 5 years ago

Fix usage of NS_LITERAL_CSTRING in mailnews, port Bug 1155963 to comm-central

Categories

(MailNews Core :: Networking: NNTP, defect, blocker)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 41.0

People

(Reporter: ssitter, Assigned: Fallen)

References

Details

(Keywords: dogfood, regression)

Attachments

(1 file)

Bug 1155963 changed how NS_LITERAL_CSTRING can be used. This currently results in Thunderbird build error like:

> mailnews/news/src/nsNntpService.cpp(732) : error C2146: syntax error : missing ')' before identifier 'kNewsRootURI'
Got a possible patch for this, stay tuned.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attached patch Fix - v1 β€” β€” Splinter Review
Attachment #8606772 - Flags: review?(rkent)
Comment on attachment 8606772 [details] [diff] [review]
Fix - v1

Review of attachment 8606772 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8606772 - Flags: review?(rkent) → review+
Pushed to comm-central changeset d6d954f11113
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
Whoops. Sorry for not checking comm-central.
Severity: normal → blocker
Keywords: dogfood, regression
You need to log in before you can comment on or make changes to this bug.