Cancel remote application reputation request after a certain timeout

VERIFIED FIXED in Firefox 41

Status

()

Toolkit
Downloads API
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: hectorz, Assigned: francois)

Tracking

(Blocks: 1 bug)

38 Branch
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
As a result of the unreliable connections to any Google service, many users in China are experiencing a long delay (in minutes) before a downloaded executable file can be marked as safe/blocked.

Beijing office would like to request introducing a timeout for application reputation check, similar to what happened in bug 1024555 for safe browsing gethash request, thanks!
(Assignee)

Comment 1

3 years ago
I'll add a similarly-configurable timeout of 5 seconds.
Assignee: nobody → francois
Status: NEW → ASSIGNED
Duplicate of this bug: 1164518
(Assignee)

Comment 3

3 years ago
Created attachment 8609129 [details]
Stalling server in node.js

Here's a test case to easily reproduce this bug.
(Assignee)

Comment 4

3 years ago
Created attachment 8609152 [details]
MozReview Request: bz://1165816/francois

/r/9239 - Bug 1165816 - Cancel remote application reputation requests after a certain timeout

Pull down this commit:

hg pull -r fcd4d3c590da5749760c48921afc47a71531e78f https://reviewboard-hg.mozilla.org/gecko/
(Assignee)

Updated

3 years ago
Component: General → Download Manager
Product: Firefox → Toolkit
(Assignee)

Comment 5

3 years ago
Comment on attachment 8609152 [details]
MozReview Request: bz://1165816/francois

/r/9239 - Bug 1165816 - Cancel remote application reputation requests after a certain timeout

Pull down this commit:

hg pull -r fcd4d3c590da5749760c48921afc47a71531e78f https://reviewboard-hg.mozilla.org/gecko/
Attachment #8609152 - Flags: review?(gpascutto)
(Assignee)

Comment 6

3 years ago
Comment on attachment 8609152 [details]
MozReview Request: bz://1165816/francois

/r/9239 - Bug 1165816 - Cancel remote application reputation requests after a certain timeout

Pull down this commit:

hg pull -r d0a637cdb6698deebc0fe02b64139d9d8f36371c https://reviewboard-hg.mozilla.org/gecko/
(Assignee)

Updated

3 years ago
QA Contact: mwobensmith
Attachment #8609152 - Flags: review?(gpascutto) → review+
(Assignee)

Comment 10

3 years ago
As per Google's suggestion, I have set the default timeout to 10 seconds.
(Assignee)

Comment 12

3 years ago
Created attachment 8616639 [details]
MozReview Request: Bug 1165816 - Cancel remote application reputation requests after a certain timeout. r=gcp

Bug 1165816 - Cancel remote application reputation requests after a certain timeout. r=gcp
Attachment #8616639 - Flags: review?(gpascutto)
(Assignee)

Comment 13

3 years ago
This new revision of the patch fixes the assertion error in Windows debug builds:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ab17fcff34b
Comment on attachment 8616639 [details]
MozReview Request: Bug 1165816 - Cancel remote application reputation requests after a certain timeout. r=gcp

https://reviewboard.mozilla.org/r/9239/#review9181

::: toolkit/components/downloads/ApplicationReputation.cpp:755
(Diff revisions 2 - 3)
> +    mTimeoutTimer->Cancel();

Maybe null that pointer here?
Attachment #8616639 - Flags: review?(gpascutto)
Comment on attachment 8616639 [details]
MozReview Request: Bug 1165816 - Cancel remote application reputation requests after a certain timeout. r=gcp

https://reviewboard.mozilla.org/r/9239/#review9183

Ship It!
Attachment #8616639 - Flags: review+
(Assignee)

Updated

3 years ago
Blocks: 662819
No longer blocks: 1090754
(Assignee)

Updated

3 years ago
Depends on: 1172689
(Assignee)

Updated

3 years ago
No longer depends on: 1172689
See Also: → bug 1172689
https://hg.mozilla.org/mozilla-central/rev/5389f1e4087c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Comment 18

3 years ago
Comment on attachment 8609152 [details]
MozReview Request: bz://1165816/francois
Attachment #8609152 - Attachment is obsolete: true
The links to malware on http://testsafebrowsing.appspot.com are no longer blocked, sadly, and I have no idea why... nor do I know how else to verify that this has been fixed.
(In reply to Matt Wobensmith from comment #19)
> The links to malware on http://testsafebrowsing.appspot.com are no longer
> blocked, sadly, and I have no idea why... nor do I know how else to verify
> that this has been fixed.

That's a problem. I can't reproduce that though, if I let my Nightly running overnight so it can update the DB, I get the blocks.

Are you on a new profile?
Yes, this is with a new profile that has been given plenty of time to download the list.

I believe all of us working on this feature have experienced intermittent issues w/r/t blocking these links, but no one has an explanation. 

I will dig into this deeper in the next week.
Today I was able to verify that this was fixed, using the links on that page. I verified using yesterday's Nightly Fx41, against an affected Nightly from 2015-05-17. 

Again, I don't know why this intermittently fails, but for the purposes of this bug, I would consider it fixed.

I still plan on investigating the intermittent failure.
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.