1172689 - Add telemetry for application reputation remote lookup timeouts

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P5)

Description

[François Marier [:francois]]

It would be useful to know how often these completions timeout when trying to reach Google's servers.

Comment 1

[François Marier [:francois]]

We should collect the same telemetry as in bug 1172688.

Comment 2

[Thomas Nguyen (:tnguyen)]

Attachment: Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

Review commit: https://reviewboard.mozilla.org/r/65506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65506/

Comment 3

[Thomas Nguyen (:tnguyen)]

Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65506/diff/1-2/

Comment 4

[Thomas Nguyen (:tnguyen)]

Hi Francois
Could you please take a look?
If you are in high review load now :), please pass it to who would be good to review it.
The telemetry will be expired in version 53.
Thanks

Comment 5

[François Marier [:francois]]

Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review62732

datareview+ and r+ but change the expiry to 55 as mentioned below

::: toolkit/components/telemetry/Histograms.json:93
(Diff revision 2)
>      "kind": "boolean",
>      "description": "Application reputation query count (both local and remote)"
>    },
> +  "APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT": {
> +    "alert_emails": ["[e-mail]", "[e-mail]"],
> +    "expires_in_version": "53",

Let's give ourselves 6 releases (Firefox 55) to examine this data.

Comment 6

[François Marier [:francois]]

Before landing please test this manually.

To get a remote lookup to timeout, you can change the browser.safebrowsing.downloads.remote.url to point to an instance of https://github.com/fmarier/stalling-server/blob/master/index.js running on localhost.

Comment 7

[Thomas Nguyen (:tnguyen)]

Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review62748

Comment 8

[Thomas Nguyen (:tnguyen)]

Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review62750

Comment 9

[Thomas Nguyen (:tnguyen)]

Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65506/diff/2-3/

Comment 10

[Thomas Nguyen (:tnguyen)]

Updated and moved the telemetry to record only remote lookup.

Comment 11

[Thomas Nguyen (:tnguyen)]

Please ignore reviewboard's trivial message here, I am playing with reviewboard, trying to resend and change review request :)

Comment 12

[Thomas Nguyen (:tnguyen)]

Manual test is ok.
Try 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0e6c48dc113&selectedJob=24278928

Comment 13

[Thomas Nguyen (:tnguyen)]

Still need to ask you to review again before landing for comment 10, moved the telemetry to record only when remote lookup.

Comment 14

[François Marier [:francois]]

Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review63726

Comment 15

[Thomas Nguyen (:tnguyen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0e6c48dc113&selectedJob=24278928

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/b6ebadfc57ba
Add telemetry for application reputation remote lookup timeouts. r=francois

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6ebadfc57ba