Closed Bug 1172689 Opened 4 years ago Closed 3 years ago

Add telemetry for application reputation remote lookup timeouts

Categories

(Toolkit :: Safe Browsing, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: francois, Assigned: tnguyen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It would be useful to know how often these completions timeout when trying to reach Google's servers.
Blocks: downloadprotection
No longer blocks: 1165816
See Also: → 1165816
We should collect the same telemetry as in bug 1172688.
Component: Download Manager → Safe Browsing
Priority: -- → P5
Whiteboard: tpe-seceng
Assignee: nobody → tnguyen
Whiteboard: tpe-seceng
Status: NEW → ASSIGNED
Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65506/diff/1-2/
Hi Francois
Could you please take a look?
If you are in high review load now :), please pass it to who would be good to review it.
The telemetry will be expired in version 53.
Thanks
Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review62732

datareview+ and r+ but change the expiry to 55 as mentioned below

::: toolkit/components/telemetry/Histograms.json:93
(Diff revision 2)
>      "kind": "boolean",
>      "description": "Application reputation query count (both local and remote)"
>    },
> +  "APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT": {
> +    "alert_emails": ["gcp@mozilla.com", "francois@mozilla.com"],
> +    "expires_in_version": "53",

Let's give ourselves 6 releases (Firefox 55) to examine this data.
Attachment #8772741 - Flags: review?(francois) → review+
Before landing please test this manually.

To get a remote lookup to timeout, you can change the browser.safebrowsing.downloads.remote.url to point to an instance of https://github.com/fmarier/stalling-server/blob/master/index.js running on localhost.
Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review62748
Attachment #8772741 - Flags: review?(tnguyen)
Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review62750
Attachment #8772741 - Flags: review?(tnguyen)
Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65506/diff/2-3/
Updated and moved the telemetry to record only remote lookup.
Please ignore reviewboard's trivial message here, I am playing with reviewboard, trying to resend and change review request :)
Still need to ask you to review again before landing for comment 10, moved the telemetry to record only when remote lookup.
Attachment #8772741 - Flags: review+ → review?(francois)
Attachment #8772741 - Flags: review?(francois) → review+
Comment on attachment 8772741 [details]
Bug 1172689 - Add telemetry for application reputation remote lookup timeouts.

https://reviewboard.mozilla.org/r/65506/#review63726
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/b6ebadfc57ba
Add telemetry for application reputation remote lookup timeouts. r=francois
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b6ebadfc57ba
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.