1165895 - Low integrity sandbox causes some crash reporting tests to fail on Windows.

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Bob Owen (:bobowen)]

From this try push we can see that a low integrity NPAPI sandbox causes some crash reporting test failures (at least on 64-bit).
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a22533ddf6c7

Failures:
3124 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_CrashService_crash.html | Test timed out. - expected PASS
3127 INFO TEST-UNEXPECTED-ERROR | dom/plugins/test/mochitest/test_CrashService_crash.html | This test did not leave any crash dumps behind, but we were expecting some!
3129 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_CrashService_crash.html | undefined assertion name - Result logged after SimpleTest.finish()
3788 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_CrashService_hang.html | Test timed out. - expected PASS
3791 INFO TEST-UNEXPECTED-ERROR | dom/plugins/test/mochitest/test_CrashService_hang.html | This test did not leave any crash dumps behind, but we were expecting some!
3793 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_CrashService_hang.html | undefined assertion name - Result logged after SimpleTest.finish()
3809 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_bug1092842.html | height of clip region rect - got 100, expected 26
3852 INFO TEST-UNEXPECTED-ERROR | dom/plugins/test/mochitest/test_crashing.html | This test did not leave any crash dumps behind, but we were expecting some!
3854 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_crashing.html | undefined assertion name - Result logged after SimpleTest.finish()
3871 INFO TEST-UNEXPECTED-ERROR | dom/plugins/test/mochitest/test_hanging.html | This test did not leave any crash dumps behind, but we were expecting some!
3873 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_hanging.html | undefined assertion name - Result logged after SimpleTest.finish()

Comment 1

[Bob Owen (:bobowen)]

Attachment: Add NPAPI sandbox rule for the crash server pipe and x64 Temp dir write access.

This was mainly just that I'd forgotten that we'd need a rule for the crash server pipe.

Also, some of the tests need to write to Temp, because they write to the temporary test profile.
I've file bug 1171393 to follow-up on this.

Try push with the crash server pipe rule:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f22a24139d44

and another with the Temp write access for x64:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d60985a2ea3

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b812439bc1ff

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b812439bc1ff