Closed Bug 1165968 Opened 8 years ago Closed 8 years ago

Change about:telemetry next/previous ping buttons to newer/older

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

(Whiteboard: [uplift])

Attachments

(2 files)

'Next' and 'Previous ping' in about:telemetry turned out to be confusing/ambiguous.

We should change the buttons to unambiguous "newer"/"older" labels.
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Attachment #8607114 - Flags: review?(rvitillo) → review+
https://hg.mozilla.org/mozilla-central/rev/faeecf37a482
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Whiteboard: [uplift]
Comment on attachment 8607114 [details] [diff] [review]
Change about:telemetry ping switch buttons to be labelled newer/older

Approval Request Comment
[Feature/regressing bug #]:
Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry
This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2.
[User impact if declined]:
Data & measurement insight projects delayed or blocked with direct impact on projects depending on this.
[Describe test coverage new/current, TreeHerder]:
We have good automation coverage of the feature.
We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here.
[Risks and why]:
Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports.
We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements.
[String/UUID change made/needed]:
The only string changes were to the about:telemetry page.
We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.
Attachment #8607114 - Flags: approval-mozilla-aurora?
This hard-codes the strings for about:telemetry per bug 1167166, comment 5 ff.
Comment on attachment 8624183 [details] [diff] [review]
Fx40 - Change about:telemetry ping switch buttons to be labelled newer/older

Approval Request Comment
[Feature/regressing bug #]:
Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry
This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2.
[User impact if declined]:
Data & measurement insight projects delayed or blocked with direct impact on projects depending on this.
[Describe test coverage new/current, TreeHerder]:
We have good automation coverage of the feature.
We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here.
[Risks and why]:
Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports.
We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements.
[String/UUID change made/needed]:
The only string changes were to the about:telemetry page, which are hard-coded in english for the uplift.
We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.
Attachment #8624183 - Flags: review+
Attachment #8624183 - Flags: approval-mozilla-aurora?
Attachment #8607114 - Flags: approval-mozilla-aurora?
Comment on attachment 8624183 [details] [diff] [review]
Fx40 - Change about:telemetry ping switch buttons to be labelled newer/older

Unified telemetry is an important new feature. It is blocking some other projects. Taking it.
Attachment #8624183 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.