Closed Bug 1165994 Opened 5 years ago Closed 4 years ago

Move marker tests to toolkit/devtools/server/tests

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox41 affected, firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox41 --- affected
firefox43 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

We should test these from the timeline actor, not from the front. Bonus points if they are easily copy/pastable for new markers
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attached patch 1165994-marker-tests.patch (obsolete) — Splinter Review
Moved e10s process communication into a helper file so it can be shared on both browser/ and toolkit/ tests, and moved marker tests to toolkit/*

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0ddc12373e5
Attachment #8649963 - Flags: review?(vporof)
Comment on attachment 8649963 [details] [diff] [review]
1165994-marker-tests.patch

Review of attachment 8649963 [details] [diff] [review]:
-----------------------------------------------------------------

Please maintain history. Use hg move to move files, qrefresh, then apply any changes on top if necessary.

I know you hate hg. I'm not doing this to make you love it.
Attachment #8649963 - Flags: review?(vporof)
Most of the marker tests are completely different (and more consistent now) -- but the moves are much more cleaner now
Attachment #8649963 - Attachment is obsolete: true
Attachment #8650555 - Flags: review?(vporof)
Also some intermittent's on markers have negative time values (both start and end) -- this seems like it makes sense, and we just filter them out, so maybe we should get rid of that assertion?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0ddc12373e5

toolkit/devtools/server/tests/browser/browser_markers-gc.js | All markers have a start time between the valid range.
Attachment #8650555 - Flags: review?(vporof) → review+
Issue with browser.ini, didn't maintain the skipping on linux (always forget the directives are below the lines they apply to), fixed up
https://hg.mozilla.org/mozilla-central/rev/dce78cf37b68
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.