Status

()

Firefox for iOS
Browser
3 years ago
3 years ago

People

(Reporter: rnewman, Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
14:36:27 < wesj> rnewman: we fire those from here https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L1215

14:38:59 < wesj> i think we can get it in - webView:decidePolicyForNavigationAction:decisionHandler: and store a Map or <NavigationAction, Reason> until the load is finished

14:39:53 < wesj> rnewman: one more link for the bug. wkwebview has these types for us:
                 https://developer.apple.com/library/ios/documentation/WebKit/Reference/WKNavigationAction_Ref/index.html#//apple_ref/c/tdef/WKNavigationType
(Reporter)

Comment 1

3 years ago
The places where WKWebView gives us a WKNavigation are not the places we get the WKNavigationAction. That makes mapping a little challenging. We can do it wherever UI code triggers navigation, at least.

The navigation types that they have -- reload, back/forward, form submit -- are almost entirely disjoint from ours -- bookmark, framed link, redirect.

To do this right will be fairly invasive, I suspect.
(Reporter)

Updated

3 years ago
Depends on: 1166121
(Reporter)

Comment 2

3 years ago
I forked the immediately achievable parts of this into Bug 1166121.
Assignee: rnewman → nobody
No longer blocks: 1157553
Mentor: rnewman, wjohnston
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.