Closed Bug 1166274 Opened 6 years ago Closed 6 years ago

[B2G][Wifi] WifiManager.setStaticIpMode() never triggers success or error event

Categories

(Firefox OS Graveyard :: Wifi, defect)

Product:
Firefox OS Graveyard
Component:
Wifi
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S14 (12june)
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(2 files)

Part 1: Fix, v1
2.97 KB, patch
vchang
: review+
Details | Diff | Splinter Review
Part 2: Test, v1
14.79 KB, patch
hchang
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1123328 +++

Found this bug when trying to write a test for static ip. Please see bug #1123328 comment #4.
Assignee: nobody → echen
Comment on attachment 8607527 [details] [diff] [review]
Part 1: Fix, v1

Review of attachment 8607527 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Vincent, would you mind reviewing this? Thank you.
Attachment #8607527 - Flags: review?(vchang)
Attachment #8607628 - Flags: review?(vchang)
Comment on attachment 8607527 [details] [diff] [review]
Part 1: Fix, v1

Review of attachment 8607527 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.
Attachment #8607527 - Flags: review?(vchang) → review+
Blocks: 1123328
Attachment #8607628 - Flags: review?(vchang) → review?(hchang)
Comment on attachment 8607628 [details] [diff] [review]
Part 2: Test, v1

Review of attachment 8607628 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks Edgar!
Attachment #8607628 - Flags: review?(hchang) → review+
https://hg.mozilla.org/mozilla-central/rev/86ab6cc5a3ae
https://hg.mozilla.org/mozilla-central/rev/e532ebecafc6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox41: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.