[B2G][Wifi] WifiManager.setStaticIpMode() never triggers success or error event
RESOLVED
FIXED
in Firefox 41
Status
People
(Reporter: edgar, Assigned: edgar)
Tracking
Firefox Tracking Flags
(firefox41 fixed)
Details
Attachments
(2 attachments)
|
2.97 KB,
patch
|
vchang
:
review+
|
Details | Diff | Splinter Review |
|
14.79 KB,
patch
|
hchang
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1123328 +++ Found this bug when trying to write a test for static ip. Please see bug #1123328 comment #4.
|
(Assignee) | |
Comment 1•4 years ago
|
||
Created attachment 8607527 [details] [diff] [review] Part 1: Fix, v1
|
|
(Assignee) | |
Comment 2•4 years ago
|
||
Created attachment 8607628 [details] [diff] [review] Part 2: Test, v1
|
|
(Assignee) | |
Updated•4 years ago
|
||
Assignee: nobody → echen
|
|
(Assignee) | |
Comment 3•4 years ago
|
||
Comment on attachment 8607527 [details] [diff] [review] Part 1: Fix, v1 Review of attachment 8607527 [details] [diff] [review]: ----------------------------------------------------------------- Hi Vincent, would you mind reviewing this? Thank you.
Attachment #8607527 -
Flags: review?(vchang)
|
|
(Assignee) | |
Updated•4 years ago
|
||
Attachment #8607628 -
Flags: review?(vchang)
|
||
Comment 4•4 years ago
|
||
Comment on attachment 8607527 [details] [diff] [review] Part 1: Fix, v1 Review of attachment 8607527 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thank you.
Attachment #8607527 -
Flags: review?(vchang) → review+
|
|
(Assignee) | |
Updated•3 years ago
|
||
Attachment #8607628 -
Flags: review?(vchang) → review?(hchang)
|
||
Comment 5•3 years ago
|
||
Comment on attachment 8607628 [details] [diff] [review] Part 2: Test, v1 Review of attachment 8607628 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Thanks Edgar!
Attachment #8607628 -
Flags: review?(hchang) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/86ab6cc5a3ae https://hg.mozilla.org/integration/b2g-inbound/rev/e532ebecafc6
|
||
Comment 7•3 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86ab6cc5a3ae https://hg.mozilla.org/mozilla-central/rev/e532ebecafc6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in
before you can comment on or make changes to this bug.
Description
•