Closed
Bug 1123328
Opened 10 years ago
Closed 7 years ago
[NetworkService] Unify the dhcp attributes in NetworkResultOptions
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(tracking-b2g:backlog)
RESOLVED
WONTFIX
| tracking-b2g | backlog |
People
(Reporter: edgar, Unassigned)
References
Details
Attachments
(1 file, 5 obsolete files)
|
18.79 KB,
patch
|
Details | Diff | Splinter Review |
There are some duplicated attributes in NetworkResultOptions for dhcp result, for example, we have |dns1_str| in `string` format and |dns1| in `long` format.
But only the `long` one is used in Wifi code [1] and will be converted to `string` format actually. So I am considering keeping only the `string` one and removing the `long` one. Other attributes (dns2, gateway, server ... etc) are in the same situation.
[1] https://dxr.mozilla.org/mozilla-central/source/dom/wifi/WifiNetUtil.jsm#62-91
|
Reporter | |
Comment 1•10 years ago
|
||
|
|
Reporter | |
Comment 2•10 years ago
|
||
I applied this patch and tested wifi connection on neux-5, wifi works good (can connect to wifi ap and browse internet), but I didn't not test static ip yet.
Attachment #8551337 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → echen
|
|
Reporter | |
Comment 3•10 years ago
|
||
Adding changes for wifi static ip.
Attachment #8551724 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 4•10 years ago
|
||
Hmm, I found an issue regarding to |MozWifiManager.setStaticIpMode| [1] when writing a test case for it.
|setStaticIpMode()| never triggers the callback [2], so the API user won't receive success or error event.
[1] https://dxr.mozilla.org/mozilla-central/source/dom/webidl/MozWifiManager.webidl#206-220
[2] https://dxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#401-436
|
||
Updated•10 years ago
|
blocking-b2g: --- → backlog
|
Assignee | |
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
|
|
Reporter | |
Comment 5•10 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #4)
> Hmm, I found an issue regarding to |MozWifiManager.setStaticIpMode| [1] when
> writing a test case for it.
> |setStaticIpMode()| never triggers the callback [2], so the API user won't
> receive success or error event.
>
> [1]
> https://dxr.mozilla.org/mozilla-central/source/dom/webidl/MozWifiManager.
> webidl#206-220
> [2]
> https://dxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#401-436
Have filed bug 1166274 for this.
|
|
Reporter | |
Comment 6•10 years ago
|
||
Attachment #8553568 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 7•10 years ago
|
||
Attachment #8616436 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 8•10 years ago
|
||
Attachment #8616444 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 9•9 years ago
|
||
Unassigning myself as I am no longer working on this.
Assignee: echen → nobody
|
||
Comment 10•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•