1166311 - config changes to support remaining mtnlion machines being changed to yosemite

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kim Moir [:kmoir] ET]

I've asked relops to reimage the remaining mtnlion machines as yosemite in bug 1166310.  This bug will track the config changes required to accommodate this change.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1166311trychooser.patch

remove 10.8 from showing up on trychooser syntax etc since we are deprecating that platform

Comment 2

[Selena Deckelmann :selenamarie :selena]

Comment on attachment 8607743 [details] [diff] [review]
bug1166311trychooser.patch

lgtm

Comment 3

[Kim Moir [:kmoir] ET]

Attachment: bug1166311.patch

patches to disable 10.8

builder diff is the same because they have already rolled off release

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: bug1166311.patch

Comment 5

[Kim Moir [:kmoir] ET]

Attachment: bug1166311builder.diff

builder diff

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1166311.patch

patch to disable 10.8 builders plus remove some old code

Comment 7

[Selena Deckelmann :selenamarie :selena]

Comment on attachment 8608166 [details] [diff] [review]
bug1166311.patch

Review of attachment 8608166 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ +2178,5 @@
>                  include_yosemite.append(name)
>  delete_slave_platform(BRANCHES, PLATFORMS, {'macosx64': 'yosemite'}, branch_exclusions=include_yosemite)
>  for branch in include_yosemite:
>      if branch in ['try']:
> +        continue   

nit: extra spaces!

Comment 8

[Kim Moir [:kmoir] ET]

Attachment: bug1165019puppet.patch

puppet patch too

Comment 9

[Kim Moir [:kmoir] ET]

Comment on attachment 8608166 [details] [diff] [review]
bug1166311.patch

tests failed

Comment 10

[Rail Aliiev [:rail]]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/73c7e83c0010

Comment 11

[Phil Ringnalda (:philor)]

I sure hope that's not really true.

Comment 12

[Kim Moir [:kmoir] ET]

It's not in production, the esr builders are still there.

Comment 13

[Kim Moir [:kmoir] ET]

Attachment: bug1166311.patch

unbitrotten patch

Comment 14

[Kim Moir [:kmoir] ET]

Attachment: bug1166311.patch

unbitrotten patch again

Comment 15

[Kim Moir [:kmoir] ET]

Attachment: bug1166311builder.diff

updated builder diff esr31 has rolled off the trains

Comment 16

[Kim Moir [:kmoir] ET]

Attachment: bug1166311slavealloc.patch

slavealloc additions

Comment 17

[Kim Moir [:kmoir] ET]

Attachment: bug1166311.patch

Comment 18

[Kim Moir [:kmoir] ET]

Attachment: bug1166311builder.diff

builder diff

Comment 19

[Kim Moir [:kmoir] ET]

Comment on attachment 8646538 [details] [diff] [review]
bug1166311.patch

disable mountain lion test slaves in configs

mountainlion-b2gdt was disabled too since they use the slave pool, I don't think they were in active use

./test-masters was clean in staging

Comment 20

[Justin Wood (:Callek)]

Comment on attachment 8646538 [details] [diff] [review]
bug1166311.patch

Review of attachment 8646538 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/b2g_config.py
@@ -81,2 @@
>  PLATFORMS['macosx64_gecko']['env_name'] = 'linux-perf'
> -PLATFORMS['macosx64_gecko']['mountainlion-b2gdt'] = {'name': builder_prefix + "_macosx64"}

can you confirm (somehow) that this is indeed not in use?

::: mozilla-tests/config.py
@@ +2425,4 @@
>  # keep debug tests on 10.8 until the source of the slowness is found in bug 1125998
>  include_yosemite = ['try']
>  for platform in PLATFORMS.keys():
>      # See Bug 997946 - skip these on OS X 10.8 due to limited capacity

s/10.8/10.10/ ?

Comment 21

[Kim Moir [:kmoir] ET]

Comment on attachment 8646538 [details] [diff] [review]
bug1166311.patch

no the b2g unittests on mtnlion aren't needed

the cpp and jittests run on various branches on 10.10 now

Comment 22

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/9372d78951d1

Comment 23

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/d94ce693b9d8

Comment 24

[Kim Moir [:kmoir] ET]

Also deleted old mtnlion slaves from slavealloc

mysql> select * from slaves where name like "%mtnlion%";
+---------+----------------------+----------+--------+---------+-----------+------+---------+-------+--------+---------------+-----------------+---------+------------------+-------+--------------+
| slaveid | name                 | distroid | bitsid | speedid | purposeid | dcid | trustid | envid | poolid | basedir       | locked_masterid | enabled | current_masterid | notes | custom_tplid |
+---------+----------------------+----------+--------+---------+-----------+------+---------+-------+--------+---------------+-----------------+---------+------------------+-------+--------------+
|    2038 | talos-mtnlion-r5-001 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              293 |       |         NULL |
|    2040 | talos-mtnlion-r5-002 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              297 |       |         NULL |
|    2041 | talos-mtnlion-r5-003 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              297 |       |         NULL |
|    2042 | talos-mtnlion-r5-004 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              295 |       |         NULL |
|    2043 | talos-mtnlion-r5-005 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |             NULL |       |         NULL |
|    2044 | talos-mtnlion-r5-006 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              293 |       |         NULL |
|    2045 | talos-mtnlion-r5-007 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              293 |       |         NULL |
|    2046 | talos-mtnlion-r5-008 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              295 |       |         NULL |
|    2047 | talos-mtnlion-r5-009 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              297 |       |         NULL |
|    2048 | talos-mtnlion-r5-010 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              293 |       |         NULL |
|    2049 | talos-mtnlion-r5-011 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              297 |       |         NULL |
|    2050 | talos-mtnlion-r5-012 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |              295 |       |         NULL |
|    2051 | talos-mtnlion-r5-013 |       16 |      2 |       8 |         4 |   10 |       4 |     2 |     65 | /builds/slave |            NULL |       0 |             NULL |       |         NULL |
+---------+----------------------+----------+--------+---------+-----------+------+---------+-------+--------+---------------+-----------------+---------+------------------+-------+--------------+
13 rows in set (0.01 sec)


mysql> delete from slaves where name like "%mtnlion%";
Query OK, 13 rows affected (0.01 sec)

mysql> select * from slaves where name like "%mtnlion%";
Empty set (0.01 sec)

Comment 25

[Kim Moir [:kmoir] ET]

enabled the new yosemite machines and am seeing green builds

Comment 26

[Chris Cooper [:coop] (he/him)]

Attachment: [buildbot-configs] Add t-yosemite-r5-0094 & t-yosemite-r5-0094

These two machines alerted all night with 'twisted.cred.error.UnauthorizedLogin' because they're not in the production slave list. Unless there's a reason I don't know about, we should add them.

Comment 27

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/2720b1d2927f

Comment 28

[Chris Cooper [:coop] (he/him)]

94 & 95 and taking jobs now.