#main-record-button[locked] should look disabled

RESOLVED FIXED in Firefox 41

Status

()

Firefox
Developer Tools: Performance Tools (Profiler/Timeline)
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jsantell, Assigned: jsantell)

Tracking

(Blocks: 1 bug)

41 Branch
Firefox 41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

We should make this more transparent or greyed out or something, or even turn it into a spinner to indicate that something is happening, and that the request did indeed work, but it just takes a few to load the profile. We have a throbber in the details pane now, but this will help to show that the button has received your action.
(Assignee)

Updated

3 years ago
Blocks: 1145697
Created attachment 8607701 [details] [diff] [review]
11663354-disabled-record.patch

Feels much better.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8607701 - Flags: review?(vporof)
Comment on attachment 8607701 [details] [diff] [review]
11663354-disabled-record.patch

Review of attachment 8607701 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/performance.inc.css
@@ +113,5 @@
>  }
>  
> +.record-button[locked] {
> +  pointer-events: none;
> +  opacity: 0.5;

No throbber? jk, this is neat.
Attachment #8607701 - Flags: review?(vporof) → review+
(Assignee)

Updated

3 years ago
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/aba162277025

Comment 4

3 years ago
The patch landed yesterday with an extra '3' in the commit message.
https://hg.mozilla.org/mozilla-central/rev/aba162277025
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.