1166354 - #main-record-button[locked] should look disabled

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

We should make this more transparent or greyed out or something, or even turn it into a spinner to indicate that something is happening, and that the request did indeed work, but it just takes a few to load the profile. We have a throbber in the details pane now, but this will help to show that the button has received your action.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 11663354-disabled-record.patch

Feels much better.

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8607701 [details] [diff] [review]
11663354-disabled-record.patch

Review of attachment 8607701 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/performance.inc.css
@@ +113,5 @@
>  }
>  
> +.record-button[locked] {
> +  pointer-events: none;
> +  opacity: 0.5;

No throbber? jk, this is neat.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

https://hg.mozilla.org/integration/fx-team/rev/aba162277025

Comment 4

[Guilherme Lima]

The patch landed yesterday with an extra '3' in the commit message.
https://hg.mozilla.org/mozilla-central/rev/aba162277025