1166469 - [Flatfish] 'class mozilla::dom::bluetooth::BluetoothHfpManager' has no member named 'HandleBackendError'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Yousef Alam [:yalam96] (use NEEDINFO)]

When building for Flatfish, I get this error.

https://pastebin.mozilla.org/8833984

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1166469-mc.patch

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8608514 [details] [diff] [review]
bug1166469-mc.patch

Review of attachment 8608514 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth/bluedroid/hfp-fallback/BluetoothHfpManager.cpp
@@ +204,5 @@
> +/*
> + * Reset connection state and audio state to DISCONNECTED to handle backend
> + * error. The state change triggers UI status bar update as ordinary bluetooth
> + * turn-off sequence.
> + */

Move this section into function body as TODO.

BluetoothHfpManager::HandleBackendError()
{
  /**
   * TODO:
   * Reset connection state and audio state ...
   ...
   */
}

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1166469 - Add HandleBackendError for hfp-fallback product, r=btian

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Because try-server won't build tablet project, ignore push to try-server.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/5f912d4afe2a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f912d4afe2a